Frontend: Secrets: Added Toggle Switch to filter helm secrets by mudit06mah · Pull Request #4412 · kubernetes-sigs/headlamp

mudit06mah · 2026-01-21T12:51:33Z

Summary

This PR adds a toggle switch to hide helm secrets

Related Issue

Changes

Changes SecretList() component to include a toggle switch in the header to hide secrets of type helm.sh/release.v1.
(It is turned on by default)

Screenshots (if applicable)

illume

Thanks for this.

Please check contributing docs for how we do commit messages? Also checks the development docs for the frontend section on how to first check your commit locally?

Copilot

Pull request overview

This PR adds a toggle switch to the Secrets list view that allows users to hide Helm secrets (secrets with type helm.sh/release.v1). The toggle is enabled by default, filtering out Helm secrets from the list view.

Changes:

Modified SecretList() component to include state management for the filter toggle
Added a FormControlLabel with Switch component in the header's titleSideActions
Implemented filtering logic to exclude helm.sh/release.v1 secrets when toggle is enabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/secret/List.tsx

mudit06mah · 2026-01-21T15:17:41Z

@illume I have created a single atomic commit following the format given in the docs, PR also passes all tests:

Ready to merge :)
P.S.: Would like to apologize again for the ruckus I caused earlier.

mudit06mah · 2026-01-25T16:48:48Z

@illume Please review this PR again as I have made the necessary changes.

frontend/src/components/secret/List.tsx

mudit06mah · 2026-02-05T12:13:35Z

Sorry for so many pushes,
@illume Can you Please Review this again? Thankyou!

mudit06mah · 2026-02-10T15:41:47Z

@illume Can you Please Review this? 👾

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/secret/List.tsx

illume

I think it’s a good idea to implement the suggestions mentioned in the comment the way you think is best. When that’s done we can get a few more perspectives on it.

(It seems like you have mostly consensus with the reviewer but one item left to find agreement on)

mudit06mah · 2026-02-12T04:57:07Z

@illume I have made the changes suggested by copilot, PTAL

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/secret/List.tsx

illume

Can you please check out some of the open review comments? It could be a couple of them are pointing out bugs.

frontend/src/components/secret/List.tsx

mudit06mah · 2026-02-12T12:25:48Z

@illume I have made the changes suggested by copilot, can you please review this again?

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/secret/List.tsx

illume · 2026-02-12T12:42:38Z

I think your implementation is quite good now. Can you please ask in the headlamp channel on the Kubernetes slack for feedback?

mudit06mah · 2026-02-12T14:19:20Z

Can you please ask in the headlamp channel on the Kubernetes slack for feedback?

Sure! 👾

kkrypt0nn

Looks good

illume

🎉 thanks!

k8s-ci-robot · 2026-02-12T17:16:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, kkrypt0nn, mudit06mah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [illume]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from ashu8912 and yolossn January 21, 2026 12:51

illume requested a review from Copilot January 21, 2026 12:55

mudit06mah mentioned this pull request Jan 21, 2026

Ability to hide/filter out Helm release secrets #4335

Closed

Copilot started reviewing on behalf of illume January 21, 2026 12:56 View session

illume requested changes Jan 21, 2026

View reviewed changes

illume marked this pull request as draft January 21, 2026 12:57

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2026

Copilot AI reviewed Jan 21, 2026

View reviewed changes

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

frontend/src/components/secret/List.tsx Show resolved Hide resolved

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

mudit06mah force-pushed the helmFilter branch 2 times, most recently from 3315ab3 to 0d06fda Compare January 21, 2026 15:14

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2026

mudit06mah requested a review from illume January 22, 2026 06:12

kkrypt0nn suggested changes Jan 27, 2026

View reviewed changes

frontend/src/components/secret/List.tsx Show resolved Hide resolved

mudit06mah changed the title ~~Fronted: Secrets: Added Toggle Switch to filter helm secrets~~ Frontend: Secrets: Added Toggle Switch to filter helm secrets Feb 2, 2026

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2026

mudit06mah force-pushed the helmFilter branch from 0d06fda to 33944dd Compare February 4, 2026 11:59

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2026

mudit06mah force-pushed the helmFilter branch from 33944dd to 6d482c9 Compare February 4, 2026 12:10

mudit06mah marked this pull request as ready for review February 4, 2026 12:11

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026

k8s-ci-robot requested review from joaquimrocha and skoeva February 4, 2026 12:11

mudit06mah marked this pull request as ready for review February 5, 2026 12:12

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2026

illume requested a review from Copilot February 11, 2026 23:51

Copilot started reviewing on behalf of illume February 11, 2026 23:52 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

frontend/src/components/secret/List.tsx Show resolved Hide resolved

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

illume requested changes Feb 12, 2026

View reviewed changes

mudit06mah force-pushed the helmFilter branch from 9cf1db0 to a98891d Compare February 12, 2026 04:50

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2026

illume requested a review from Copilot February 12, 2026 09:34

Copilot started reviewing on behalf of illume February 12, 2026 09:34 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

illume requested changes Feb 12, 2026

View reviewed changes

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

frontend/src/components/secret/List.tsx Outdated Show resolved Hide resolved

frontend/src/components/secret/List.tsx Show resolved Hide resolved

mudit06mah force-pushed the helmFilter branch from a98891d to 832bd26 Compare February 12, 2026 12:23

illume requested a review from Copilot February 12, 2026 12:36

Copilot started reviewing on behalf of illume February 12, 2026 12:37 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

frontend/src/components/secret/List.tsx Show resolved Hide resolved

frontend: component: Add helm secrets filter switch

c14c00e

mudit06mah force-pushed the helmFilter branch from 832bd26 to c14c00e Compare February 12, 2026 14:18

kkrypt0nn approved these changes Feb 12, 2026

View reviewed changes

illume approved these changes Feb 12, 2026

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026

illume merged commit ed9749a into kubernetes-sigs:main Feb 12, 2026
11 of 12 checks passed

Conversation

mudit06mah commented Jan 21, 2026

Summary

Related Issue

Changes

Screenshots (if applicable)

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mudit06mah commented Jan 21, 2026

Uh oh!

mudit06mah commented Jan 25, 2026

Uh oh!

Uh oh!

mudit06mah commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mudit06mah commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

mudit06mah commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mudit06mah commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

illume commented Feb 12, 2026

Uh oh!

mudit06mah commented Feb 12, 2026

Uh oh!

kkrypt0nn left a comment

Choose a reason for hiding this comment

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mudit06mah commented Feb 5, 2026 •

edited

Loading