feat(ui): add multi-cluster user logout by alokdangre · Pull Request #4425 · kubernetes-sigs/headlamp

alokdangre · 2026-01-23T09:24:35Z

Summary

Visual support for displaying authenticated users per cluster in TopBar.
Implemented individual cluster logout functionality.
Added SelfSubjectReview API support for fetching user info.
Fixed multi-cluster selection state bug in useSelectedClusters hook.
Improved logout UX to persist view on remaining clusters.

Related Issue

Fixes #4082

Changes

Updated TopBar.tsx component, clusterApi

Steps to Test

select multiple clusters to view
click on user menu,
click on logout options

Screenshots (if applicable)

Screen.Recording.2026-01-23.145438.mp4

linux-foundation-easycla · 2026-01-23T09:24:44Z

The committers listed above are authorized under a signed CLA.

✅ login: alokdangre / name: Alok Dangre (03c29fd, 11a4e19, 21534b7, 3b20d05, d4e21f4)

k8s-ci-robot · 2026-01-23T09:24:45Z

Welcome @alokdangre!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

illume

Thanks for this!

Can you please check the git commit guidelines in the development documentation and update your commit message? You can compare your message to other ones.

The frontend tests are failing in the GitHub check. Can you please try running the tests locally? Also, can you please add a storybook state for this?

Copilot

Pull request overview

Adds multi-cluster-aware user identity display and logout behavior in the TopBar, including a hook fix to keep multi-cluster selection derived from the URL in sync.

Changes:

Updated TopBar to fetch/display per-cluster authenticated user info and provide per-cluster (and “logout all”) actions.
Added SelfSubjectReview-based user info fetching (getClusterUserInfo) in the v1 cluster API layer.
Fixed useSelectedClusters to react to pathname changes (not only cluster changes) for correct multi-cluster state updates.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
frontend/src/lib/k8s/index.ts	Updates `useSelectedClusters` to recompute when `location.pathname` changes.
frontend/src/lib/k8s/api/v1/clusterApi.ts	Adds `ClusterUserInfo` + `getClusterUserInfo()` using the SelfSubjectReview API with fallback behavior.
frontend/src/components/App/TopBar.tsx	Implements multi-cluster user menu UX, per-cluster logout, and queries user info for selected clusters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/lib/k8s/api/v1/clusterApi.ts

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/App/TopBar.tsx

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/App/TopBar.stories.tsx

frontend/src/components/App/TopBar.tsx

frontend/src/components/App/TopBar.stories.tsx

alokdangre · 2026-01-25T14:12:32Z

@illume sorry for that test error, i forgot to take snapshot, i have also added the requested changes

alokdangre · 2026-01-28T15:11:12Z

@illume ptal

joaquimrocha · 2026-02-03T15:42:12Z

@illume ,

There is precedent for wanting to logout with only one account in a few apps when you can sign in multiple times. For example, inside MS products that allow multiple logins it's possible to select which login you want to sign-out with. I use this functionality personally in a few different websites.

Sure, but this I would say is the equivalent of logging out of a cluster from the home view, which is showing all clusters there.
In this PR we are saying that users group clusters together (which do not get saved anywhere, it's an intentional and temporary measure), and from this aggregated view they want to log out from a single cluster.

I would err on not providing this option and instead just the "Log out of these grouped clusters" if we need a log out from all while visualizing a group of clusters.

Implement getClusterUserInfo in clusterApi to fetch user details using SelfSubjectReview. Export the function in apiProxy and add unit tests. Signed-off-by: alokdangre <alokdangre@gmail.com>

…anges Update useSelectedClusters to use useLocation and track pathname changes, fixing a bug where cluster selection state could become stale. Signed-off-by: alokdangre <alokdangre@gmail.com>

Fetch and display authenticated user information per cluster in the user menu. Fallback to showing the cluster name if no user info is available. Update TopBar stories to reflect multi-user scenarios. Update e2e tests to match the new menu item structure. Signed-off-by: alokdangre <alokdangre@gmail.com>

illume · 2026-02-10T19:37:22Z

@alokdangre what do you think of the last comment?

If it’s not clear, can you please ask Joaquim to expand on the bits that aren’t clear? If you disagree on some points, can you please explain why?

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/App/TopBar.tsx

alokdangre · 2026-02-12T06:12:44Z

@illume ,

There is precedent for wanting to logout with only one account in a few apps when you can sign in multiple times. For example, inside MS products that allow multiple logins it's possible to select which login you want to sign-out with. I use this functionality personally in a few different websites.

Sure, but this I would say is the equivalent of logging out of a cluster from the home view, which is showing all clusters there. In this PR we are saying that users group clusters together (which do not get saved anywhere, it's an intentional and temporary measure), and from this aggregated view they want to log out from a single cluster.

I would err on not providing this option and instead just the "Log out of these grouped clusters" if we need a log out from all while visualizing a group of clusters.

this seems good to me,
but my logic behind implementing the logout from specific cluster during multicluster view is that,
becuase it is just a view of group of cluster, sometimes, user may don't want any cluster to view from his selected cluster of view, so instead of going back again and selecting again, he can just remove it by logging out
that's what i thought
but @joaquimrocha consideration seems also right to me
so i will remove the logout from specific cluster logic and only keep logout from all
@illume .

Add logic to handle logout from specific clusters in a multi-cluster context. Update the URL to remove the logged-out cluster while persisting the view for remaining clusters. Signed-off-by: alokdangre <alokdangre@gmail.com>

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/src/components/App/TopBar.tsx

frontend/src/components/App/TopBar.stories.tsx

illume

Thanks! 🎉

I won’t merge it yet, will leave it open a bit longer to give Joaquim or others another chance to have a look.

k8s-ci-robot · 2026-02-12T10:08:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alokdangre, illume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [illume]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

joaquimrocha

Found some code that can be optimized for readability.

frontend/src/components/App/TopBar.utils.ts

Remove per-cluster logout functionality as it is not desired. Add unit tests for handleLogoutPathUpdate and ensure stories use isolated query clients. Signed-off-by: alokdangre <alokdangre@gmail.com>

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 23, 2026

k8s-ci-robot requested a review from ashu8912 January 23, 2026 09:24

k8s-ci-robot requested a review from yolossn January 23, 2026 09:24

alokdangre force-pushed the feature/multi-cluster-user-logout branch from 4fa5f4b to a9ece5c Compare January 23, 2026 09:31

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 23, 2026

illume requested a review from Copilot January 24, 2026 20:18

Copilot started reviewing on behalf of illume January 24, 2026 20:19 View session

illume requested changes Jan 24, 2026

View reviewed changes

Copilot AI reviewed Jan 24, 2026

View reviewed changes

frontend/src/lib/k8s/api/v1/clusterApi.ts Show resolved Hide resolved

frontend/src/lib/k8s/api/v1/clusterApi.ts Outdated Show resolved Hide resolved

alokdangre force-pushed the feature/multi-cluster-user-logout branch from a9ece5c to a61d03c Compare January 25, 2026 11:45

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2026

alokdangre requested review from Copilot and illume January 25, 2026 11:47

Copilot started reviewing on behalf of alokdangre January 25, 2026 11:47 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

frontend/src/components/App/TopBar.tsx Outdated Show resolved Hide resolved

alokdangre force-pushed the feature/multi-cluster-user-logout branch from a61d03c to 0c38f12 Compare January 25, 2026 11:59

illume requested a review from Copilot January 25, 2026 13:23

Copilot started reviewing on behalf of illume January 25, 2026 13:23 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

illume requested a review from Copilot January 29, 2026 17:34

Copilot started reviewing on behalf of illume January 29, 2026 17:35 View session

illume modified the milestones: v0.40.0, v0.41.0 Feb 4, 2026

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2026

alokdangre added 3 commits February 5, 2026 13:58

frontend: k8s: Add getClusterUserInfo API support

21534b7

Implement getClusterUserInfo in clusterApi to fetch user details using SelfSubjectReview. Export the function in apiProxy and add unit tests. Signed-off-by: alokdangre <alokdangre@gmail.com>

frontend: lib: Fix useSelectedClusters hook to correctly track URL ch…

d4e21f4

…anges Update useSelectedClusters to use useLocation and track pathname changes, fixing a bug where cluster selection state could become stale. Signed-off-by: alokdangre <alokdangre@gmail.com>

alokdangre force-pushed the feature/multi-cluster-user-logout branch from a806ab8 to fe0a589 Compare February 5, 2026 14:14

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2026

illume requested a review from Copilot February 10, 2026 19:35

Copilot started reviewing on behalf of illume February 10, 2026 19:36 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

frontend/src/components/App/TopBar.tsx Outdated Show resolved Hide resolved

frontend/src/components/App/TopBar.tsx Outdated Show resolved Hide resolved

alokdangre force-pushed the feature/multi-cluster-user-logout branch from fe0a589 to d1b2010 Compare February 12, 2026 07:23

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2026

alokdangre force-pushed the feature/multi-cluster-user-logout branch from d1b2010 to 03c29fd Compare February 12, 2026 07:30

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 12, 2026

illume requested a review from Copilot February 12, 2026 09:04

Copilot started reviewing on behalf of illume February 12, 2026 09:04 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

frontend/src/components/App/TopBar.tsx Outdated Show resolved Hide resolved

frontend/src/components/App/TopBar.stories.tsx Show resolved Hide resolved

illume approved these changes Feb 12, 2026

View reviewed changes

joaquimrocha requested changes Feb 12, 2026

View reviewed changes

frontend/src/components/App/TopBar.utils.ts Outdated Show resolved Hide resolved

alokdangre force-pushed the feature/multi-cluster-user-logout branch from 824137e to 3b20d05 Compare February 12, 2026 11:32

frontend: TopBar: Remove per-cluster logout & add tests

3b20d05

Remove per-cluster logout functionality as it is not desired. Add unit tests for handleLogoutPathUpdate and ensure stories use isolated query clients. Signed-off-by: alokdangre <alokdangre@gmail.com>

alokdangre requested a review from joaquimrocha February 13, 2026 09:53

Conversation

alokdangre commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Steps to Test

Screenshots (if applicable)

Uh oh!

linux-foundation-easycla bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 23, 2026

Uh oh!

illume left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alokdangre commented Jan 25, 2026

Uh oh!

alokdangre commented Jan 28, 2026

Uh oh!

joaquimrocha commented Feb 3, 2026

Uh oh!

illume commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

alokdangre commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

illume left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 12, 2026

Uh oh!

joaquimrocha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

alokdangre commented Jan 23, 2026 •

edited

Loading

linux-foundation-easycla bot commented Jan 23, 2026 •

edited

Loading

illume left a comment •

edited

Loading

illume left a comment •

edited

Loading