Added Light mode for logs#4432
Conversation
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
skoeva
left a comment
There was a problem hiding this comment.
Hi! Could you update the snapshots with make frontend-test?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: greedy-wudpeckr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hi, sorry we already have a PR for reworked logs component that supports light mode |
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
|
PTAL @skoeva , done with the changes |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @greedy-wudpeckr for this, but closing because there’s a PR that was already open that also addresses this issue. |
Summary
Related Issue
Fixes #4430
Changes
Steps to Test
Check for logs