Skip to content

frontend: project: Disable assigned namespaces in project creation #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pallava-joshi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

frontend: project: Disable assigned namespaces in project creation #4451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions frontend/src/components/project/NewProjectPopup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
useTheme,
} from '@mui/material';
import { uniq } from 'lodash';
import { ReactNode, useCallback, useMemo, useState } from 'react';
import { ReactNode, useCallback, useEffect, useMemo, useState } from 'react';
import { Trans, useTranslation } from 'react-i18next';
import { useHistory } from 'react-router';
import { useClustersConf } from '../../lib/k8s';
Expand Down Expand Up @@ -136,12 +136,35 @@ function ProjectFromExistingNamespace({ onBack }: { onBack: () => void }) {
// Check if project name already exists (using normalized form to match existing entries)
const projectNameExists =
projectName.length > 0 && existingProjectNames.has(toKubernetesName(projectName));
const namespaceToProjectMap = useMemo(() => {
const map = new Map<string, string>();
if (!namespaces) return map;
namespaces.forEach(ns => {
const projectId = ns.metadata?.labels?.[PROJECT_ID_LABEL];
if (projectId) {
map.set(ns.metadata.name, projectId);
}
});
return map;
}, [namespaces]);

const effectiveNamespace = selectedNamespace || toKubernetesName(typedNamespace);
const isNamespaceAlreadyAssigned = effectiveNamespace
? namespaceToProjectMap.has(effectiveNamespace)
: false;

const isReadyToCreate =
selectedClusters.length &&
(selectedNamespace || typedNamespace) &&
projectName &&
!projectNameExists;
!projectNameExists &&
!isNamespaceAlreadyAssigned;

useEffect(() => {
if (selectedNamespace && namespaceToProjectMap.has(selectedNamespace)) {
setSelectedNamespace(undefined);
}
}, [selectedNamespace, namespaceToProjectMap]);

/**
* Creates or updates namespaces for the project
Expand Down Expand Up @@ -285,6 +308,7 @@ function ProjectFromExistingNamespace({ onBack }: { onBack: () => void }) {
onInputChange={(e, v) => {
setTypedNamespace(v);
}}
getOptionDisabled={option => namespaceToProjectMap.has(option)}
renderInput={params => (
<TextField
{...params}
Expand Down
Loading