Skip to content

helm: Add ability to set scheme for probes #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gambtho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

helm: Add ability to set scheme for probes #4478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions charts/headlamp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,42 @@ httpRoute:
port: 80
```

### Probe Configuration

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| probes.scheme | string | `"HTTP"` | Scheme for liveness/readiness probes (HTTP or HTTPS). Set to HTTPS when TLS is enabled at the backend. |
| probes.livenessProbe.initialDelaySeconds | int | `0` | Initial delay before liveness probe starts |
| probes.livenessProbe.periodSeconds | int | `10` | Period between liveness checks |
| probes.livenessProbe.timeoutSeconds | int | `1` | Timeout for liveness probe |
| probes.livenessProbe.successThreshold | int | `1` | Must be 1 for liveness probes (Kubernetes requirement) |
| probes.livenessProbe.failureThreshold | int | `3` | Minimum consecutive failures |
| probes.readinessProbe.initialDelaySeconds | int | `0` | Initial delay before readiness probe starts |
| probes.readinessProbe.periodSeconds | int | `10` | Period between readiness checks |
| probes.readinessProbe.timeoutSeconds | int | `1` | Timeout for readiness probe |
| probes.readinessProbe.successThreshold | int | `1` | Minimum consecutive successes |
| probes.readinessProbe.failureThreshold | int | `3` | Minimum consecutive failures |

When using TLS termination at the backend server, you must set `probes.scheme` to `HTTPS`:

```yaml
config:
tlsCertPath: "/headlamp-cert/tls.crt"
tlsKeyPath: "/headlamp-cert/tls.key"

probes:
scheme: HTTPS # Required when TLS is enabled at backend

volumes:
- name: headlamp-cert
secret:
secretName: headlamp-tls

volumeMounts:
- name: headlamp-cert
mountPath: /headlamp-cert
```

### Resource Management

| Key | Type | Default | Description |
Expand Down
12 changes: 12 additions & 0 deletions charts/headlamp/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,22 @@ spec:
httpGet:
path: "{{ .Values.config.baseURL }}/"
port: http
scheme: {{ .Values.probes.scheme | default "HTTP" }}
initialDelaySeconds: {{ .Values.probes.livenessProbe.initialDelaySeconds | default 0 }}
periodSeconds: {{ .Values.probes.livenessProbe.periodSeconds | default 10 }}
timeoutSeconds: {{ .Values.probes.livenessProbe.timeoutSeconds | default 1 }}
successThreshold: 1
failureThreshold: {{ .Values.probes.livenessProbe.failureThreshold | default 3 }}
readinessProbe:
httpGet:
path: "{{ .Values.config.baseURL }}/"
port: http
scheme: {{ .Values.probes.scheme | default "HTTP" }}
initialDelaySeconds: {{ .Values.probes.readinessProbe.initialDelaySeconds | default 0 }}
periodSeconds: {{ .Values.probes.readinessProbe.periodSeconds | default 10 }}
timeoutSeconds: {{ .Values.probes.readinessProbe.timeoutSeconds | default 1 }}
successThreshold: {{ .Values.probes.readinessProbe.successThreshold | default 1 }}
failureThreshold: {{ .Values.probes.readinessProbe.failureThreshold | default 3 }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- if or .Values.pluginsManager.enabled .Values.volumeMounts }}
Expand Down
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/azure-oidc-with-validators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/extra-args.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/extra-manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/host-users-override.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/httproute-enabled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,22 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
---
Expand Down
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/me-user-info-url-directly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/me-user-info-url.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/namespace-override-oidc-create-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/namespace-override.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/non-azure-oidc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/oidc-create-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/oidc-directly-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/oidc-directly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
12 changes: 12 additions & 0 deletions charts/headlamp/tests/expected_templates/oidc-external-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,21 @@ spec:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
readinessProbe:
httpGet:
path: "/"
port: http
scheme: HTTP
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 1
successThreshold: 1
failureThreshold: 3
resources:
{}
Loading
Loading