Skip to content

feat(charts): add revisionHistoryLimit to deployment #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zyzzmohit wants to merge 1 commit into
base: main
Choose a base branch
from
+129 −109
Open

feat(charts): add revisionHistoryLimit to deployment #4639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/headlamp/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ sources:
maintainers:
- name: kinvolk
url: https://kinvolk.io/
version: 0.40.0
version: 0.40.1
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart version was bumped to 0.40.1, which will change the rendered helm.sh/chart label and will cause the Helm chart snapshot tests in charts/headlamp/tests/expected_templates/ to fail unless they are regenerated/updated. Please update the expected templates to match the new chart version.

Copilot uses AI. Check for mistakes.
appVersion: 0.40.0
annotations:
artifacthub.io/signKey: |
Expand Down
1 change: 1 addition & 0 deletions charts/headlamp/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ metadata:
{{- end }}
spec:
replicas: {{ .Values.replicaCount }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding revisionHistoryLimit to the Deployment changes the rendered manifests, but the Helm chart snapshot tests under charts/headlamp/tests/expected_templates/ still reflect the old output. Update the expected templates (and ideally add a test case exercising a non-default override) so CI doesn’t fail and the new value is covered.

Copilot uses AI. Check for mistakes.
selector:
matchLabels:
{{- include "headlamp.selectorLabels" . | nindent 6 }}
Expand Down
9 changes: 5 additions & 4 deletions charts/headlamp/tests/expected_templates/azure-oidc-with-validators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -18,7 +18,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -39,7 +39,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -66,13 +66,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down
9 changes: 5 additions & 4 deletions charts/headlamp/tests/expected_templates/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -27,7 +27,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -48,7 +48,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -75,13 +75,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down
9 changes: 5 additions & 4 deletions charts/headlamp/tests/expected_templates/extra-args.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -27,7 +27,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -48,7 +48,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -75,13 +75,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down
9 changes: 5 additions & 4 deletions charts/headlamp/tests/expected_templates/extra-manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand Down Expand Up @@ -44,7 +44,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -65,7 +65,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -92,13 +92,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down
9 changes: 5 additions & 4 deletions charts/headlamp/tests/expected_templates/host-users-override.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -27,7 +27,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -48,7 +48,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -75,13 +75,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down
11 changes: 6 additions & 5 deletions charts/headlamp/tests/expected_templates/httproute-enabled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -27,7 +27,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -48,7 +48,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -75,13 +75,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down Expand Up @@ -136,7 +137,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand Down
9 changes: 5 additions & 4 deletions charts/headlamp/tests/expected_templates/me-user-info-url-directly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -27,7 +27,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -48,7 +48,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -75,13 +75,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down
9 changes: 5 additions & 4 deletions charts/headlamp/tests/expected_templates/me-user-info-url.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -28,7 +28,7 @@ kind: ClusterRoleBinding
metadata:
name: headlamp-admin
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -49,7 +49,7 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
Expand All @@ -76,13 +76,14 @@ metadata:
name: headlamp
namespace: default
labels:
helm.sh/chart: headlamp-0.40.0
helm.sh/chart: headlamp-0.40.1
app.kubernetes.io/name: headlamp
app.kubernetes.io/instance: headlamp
app.kubernetes.io/version: "0.40.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
revisionHistoryLimit: 10
selector:
matchLabels:
app.kubernetes.io/name: headlamp
Expand Down
Loading
Loading