Skip to content

frontend: DropZoneBox: Remove role=button from label element #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Vaishnav-Dhaval wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −12
Draft

frontend: DropZoneBox: Remove role=button from label element #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend/src/components/common/DropZoneBox.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ UploadFiles.args = {
<Typography sx={{ m: 2 }}>{'Select a file or drag and drop here'}</Typography>
<Button
variant="contained"
component="label"
startIcon={<InlineIcon icon="mdi:upload" width={32} />}
sx={{ fontWeight: 500 }}
>
Expand Down
18 changes: 10 additions & 8 deletions frontend/src/components/common/Resource/UploadDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ const UploadFromFilesystem = ({
const [files, setFiles] = React.useState<File[]>([]);
const [dragOver, setDragOver] = React.useState(false);
const [error, setError] = React.useState('');
const fileInputRef = React.useRef<HTMLInputElement>(null);

const onFilesPicked = (picked: FileList | null) => {
setError('');
Expand Down Expand Up @@ -123,19 +124,20 @@ const UploadFromFilesystem = ({
</Typography>
<Button
variant="contained"
component="label"
startIcon={<InlineIcon icon="mdi:upload" width={32} />}
sx={{ fontWeight: 500 }}
onClick={() => fileInputRef.current?.click()}
>
{t('translation|Select File')}
<input
type="file"
accept=".yaml,.yml,application/yaml"
multiple
hidden
onChange={e => onFilesPicked(e.target.files)}
/>
</Button>
<input
type="file"
accept=".yaml,.yml,application/yaml"
multiple
hidden
ref={fileInputRef}
onChange={e => onFilesPicked(e.target.files)}
/>
</DropZoneBox>
{!!files.length && (
<Box
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/common/__snapshots__/DropZoneBox.UploadFiles.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
>
Select a file or drag and drop here
</p>
<label
<button
class="MuiButtonBase-root MuiButton-root MuiButton-contained MuiButton-containedPrimary MuiButton-sizeMedium MuiButton-containedSizeMedium MuiButton-colorPrimary MuiButton-disableElevation MuiButton-root MuiButton-contained MuiButton-containedPrimary MuiButton-sizeMedium MuiButton-containedSizeMedium MuiButton-colorPrimary MuiButton-disableElevation css-17g4n8r-MuiButtonBase-root-MuiButton-root"
role="button"
tabindex="0"
type="button"
>
<span
class="MuiButton-icon MuiButton-startIcon MuiButton-iconSizeMedium css-1d6wzja-MuiButton-startIcon"
Expand All @@ -20,7 +20,7 @@
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</label>
</button>
</div>
</div>
</body>
Loading