Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zyzzmohit The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can you please see the git commit guidelines in the contributing guide? |
illume
left a comment
There was a problem hiding this comment.
Can you please see the git commit guidelines in the contributing guide?
I think there's a merge problem here, because there's 744 files changed.
There was a problem hiding this comment.
Pull request overview
Resolves build failures by aligning frontend typings/docs output with updated config shape and updating Helm chart rendering/tests for the new default “warnings-only events” filter.
Changes:
- Adds a new
filters-warnings-onlybackend flag and exposes it via the/configclient config response. - Updates Helm chart defaults and deployment args to pass
-filters-warnings-only, and regenerates expected templates. - Regenerates API docs output (large churn: removing old generated pages and adding new ones).
Reviewed changes
Copilot reviewed 181 out of 744 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/development/api/interfaces/plugin_registry.PodAttachEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.PluginsLoadedEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.PluginSettingsDetailsProps.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.PluginLoadingErrorEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.LogsEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.HeadlampEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.EventListEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.ErrorBoundaryEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.EditResourceEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.DetailsViewSectionProps.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.DeleteResourceEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.CreateResourceEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.ClusterChooserProps.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_registry.AppLogoProps.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/plugin_lib.AppMenu.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_util.TimeAgoOptions.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_router.RouteURLProps.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_router.Route.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_vpa.KubeVPA.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_validatingWebhookConfiguration.KubeValidatingWebhookConfiguration.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_token.KubeToken.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_storageClass.KubeStorageClass.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_statefulSet.KubeStatefulSet.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_serviceAccount.KubeServiceAccount.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_service.KubeService.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_service.KubePortStatus.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_service.KubeLoadBalancerIngress.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_secret.KubeSecret.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_runtime.KubeRuntimeClass.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_roleBinding.KubeRoleBinding.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_role.KubeRole.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_resourceQuota.KubeResourceQuota.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_replicaSet.KubeReplicaSet.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_priorityClass.KubePriorityClass.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_podDisruptionBudget.KubePDB.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_pod.LogOptions.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_pod.KubeVolume.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_pod.KubePodSpec.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_pod.KubePod.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_pod.ExecOptions.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_persistentVolumeClaim.KubePersistentVolumeClaim.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_persistentVolume.KubePersistentVolume.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_node.KubeNode.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_networkpolicy.NetworkPolicyPort.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_networkpolicy.NetworkPolicyPeer.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_networkpolicy.NetworkPolicyIngressRule.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_networkpolicy.NetworkPolicyEgressRule.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_networkpolicy.KubeNetworkPolicy.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_networkpolicy.IPBlock.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_namespace.KubeNamespace.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_mutatingWebhookConfiguration.KubeWebhookClientConfig.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_mutatingWebhookConfiguration.KubeRuleWithOperations.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_mutatingWebhookConfiguration.KubeMutatingWebhookConfiguration.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_limitRange.LimitRangeSpec.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_limitRange.KubeLimitRange.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_lease.LeaseSpec.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_lease.KubeLease.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_kubeconfig.KubeconfigObject.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_job.KubeJob.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_ingressClass.KubeIngressClass.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_ingress.KubeIngress.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_ingress.IngressRule.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_ingress.IngressBackend.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_hpa.KubeHPA.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_hpa.CrossVersionObjectReference.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_event.KubeEvent.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_endpoints.KubeEndpointSubset.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_endpoints.KubeEndpointPort.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_endpoints.KubeEndpointAddress.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_endpoints.KubeEndpoint.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_deployment.KubeDeployment.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_daemonSet.KubeDaemonSet.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cronJob.KubeCronJob.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_crd.KubeCRD.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_crd.CRClassArgs.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_configMap.KubeConfigMap.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.StringDict.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.LabelSelector.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeOwnerReference.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeObjectInterface.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeObjectIface.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeMetrics.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeManagedFields.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeContainerStatus.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeContainerProbe.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.KubeCondition.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.ContainerState.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.Cluster.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.AuthRequestResourceAttrs.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_cluster.ApiListSingleNamespaceOptions.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.StreamResultsParams.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.StreamArgs.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.RequestParams.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.QueryParameters.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.ClusterRequestParams.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.ClusterRequest.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.ApiInfo.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/interfaces/lib_k8s_apiProxy.ApiError.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/enums/plugin_registry.DefaultSidebars.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/enums/plugin_registry.DefaultDetailsViewSection.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/enums/plugin_registry.DefaultAppBarAction.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/classes/plugin_registry.Registry.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/classes/plugin_registry.PluginManager.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/classes/plugin_lib.Plugin.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/classes/plugin_lib.Headlamp.md | Removes old generated TypeDoc page (regen) |
| docs/development/api/components/activity/Activity/API.md | Adds new generated TypeDoc module index |
| docs/development/api/components/activity/Activity/variables/Activity.md | Adds new generated TypeDoc variable page |
| docs/development/api/components/activity/Activity/interfaces/Activity.md | Adds new generated TypeDoc interface page |
| docs/development/api/components/activity/Activity/functions/useActivity.md | Adds new generated TypeDoc function page |
| docs/development/api/components/activity/Activity/functions/SingleActivityRenderer.md | Adds new generated TypeDoc function page |
| docs/development/api/components/activity/Activity/functions/ActivityBar.md | Adds new generated TypeDoc function page |
| docs/development/api/components/activity/Activity/functions/ActivitiesRenderer.md | Adds new generated TypeDoc function page |
| docs/development/api/API.md | Updates top-level API index after TypeDoc regen |
| docs/development/api/.nojekyll | Removes TypeDoc GH Pages/Jekyll bypass file |
| charts/headlamp/values.yaml | Adds Helm default for events warnings-only and normalizes some YAML formatting |
| charts/headlamp/templates/deployment.yaml | Passes -filters-warnings-only flag to container args |
| charts/headlamp/tests/expected_templates/default.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/extra-args.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/extra-manifests.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/host-users-override.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/httproute-enabled.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/me-user-info-url.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/me-user-info-url-directly.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/namespace-override.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/namespace-override-oidc-create-secret.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/non-azure-oidc.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/oidc-create-secret.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/oidc-directly.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/oidc-directly-env.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/oidc-external-secret.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/oidc-pkce.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/oidc-validator-overrides.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/azure-oidc-with-validators.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/pod-disruption.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/security-context.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/tls-added.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/topology-spread-constraints.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/topology-spread-constraints-custom-selector.yaml | Updates expected manifest with new arg |
| charts/headlamp/tests/expected_templates/volumes-added.yaml | Updates expected manifest with new arg |
| backend/pkg/headlampconfig/headlampConfig.go | Adds config fields for Prometheus endpoint and warnings-only default |
| backend/pkg/config/config.go | Adds filters-warnings-only config + CLI flag |
| backend/cmd/stateless.go | Includes new fields in stateless client config response |
| backend/cmd/headlamp.go | Includes new fields in primary client config response |
Comments suppressed due to low confidence (1)
docs/development/api/.nojekyll:1
- Removing
.nojekyllcan affect GitHub Pages rendering (Jekyll processing may ignore certain paths/files). If API docs are still published via GitHub Pages, either keep.nojekyllor ensure the publishing setup explicitly disables Jekyll so the generated docs are served correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{- with .Values.config.tlsKeyPath }} | ||
| - "-tls-key-path={{ . }}" | ||
| {{- end }} | ||
| - "-filters-warnings-only={{ .Values.config.events.warningsOnly }}" |
There was a problem hiding this comment.
This direct nested lookup can fail Helm rendering when a user overrides config without an events map (e.g. config: {}), because .Values.config.events becomes nil and .warningsOnly can’t be evaluated. Use a safe lookup like dig (with a default of true) to avoid template evaluation errors when intermediate maps are missing.
| - "-filters-warnings-only={{ .Values.config.events.warningsOnly }}" | |
| - "-filters-warnings-only={{ dig "config" "events" "warningsOnly" true .Values }}" |
|
|
||
| ### update() | ||
|
|
||
| Update existing activity with a partial changes |
There was a problem hiding this comment.
Grammar issue in generated docs: 'a partial changes' should be 'partial changes' (or 'a partial change'). Consider fixing the underlying source comment so regenerated docs read correctly.
| Update existing activity with a partial changes | |
| Update existing activity with partial changes |
|
Hello. Please let us know if you want to finish this? If not, please close? Thanks :) |
9f89671 to
7a12300
Compare
Hi! Yes, I'm still working on this. I've just force-pushed a cleaned-up version of the branch — it's now rebased on the latest main with a single commit and only 33 files changed (down from 744). I removed all the unrelated changes (regenerated API docs, submodule, package-lock, formatting noise) and fixed the commit message to follow the project guidelines. Would appreciate a re-review when CI passes. Thanks for the patience :) |
Add a configuration option to set the default state of the events warning filter. Configurable via Helm chart value 'config.events.warningsOnly' or backend flag '-filters-warnings-only'. The frontend reads this value as the default if the user has not set a preference. Signed-off-by: zyzzmohit <mohitray949@gmail.com>
7a12300 to
ea39f23
Compare
fix(build): Resolve frontend type errors and update helm test templates
📋 Summary
This PR addresses build failures found in #4646. It resolves TypeScript errors in the frontend build process (specifically
build-typedoc) and updates the Helm chart expected templates to align with the new default configuration for event severity filtering.🐛 Issues Fixed
build-typedoccommand was failing due to a strict TypeScript check. ThefiltersWarningsOnlyproperty was required in ConfigState but missing from mock states in configSlice.test.ts and Storybook stories.helm-lint-teststep failed because the new defaultconfig.events.warningsOnly: trueintroduced a new flag (-filters-warnings-only=true) into the rendered deployment templates, causing a mismatch with the existing expected templates.🛠️ Changes
Frontend
filtersWarningsOnlyoptional in the setConfig action payload to allow partial updates in tests.filtersWarningsOnly: trueto the mock state in NewProjectPopup.stories.tsx and ProjectCreateFromYaml.stories.tsx to fix type errors.Helm Charts
charts/headlamp/tests/expected_templates/usinghelm templateto include the new default-filters-warnings-only=trueargument. This ensures all test cases now pass with the new configuration.✅ Verification
I have verified these fixes locally with the following commands:
npm run build-typedoc(PASSED)npm run buildinplugins/headlamp-plugin(PASSED)🏎️ Type of Change
🔗 Related Issues
Fixes build failures in #4646