frontend: SettingsCluster stories for cluster settings states#4707
frontend: SettingsCluster stories for cluster settings states#4707greedy-wudpeckr wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: greedy-wudpeckr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive Storybook stories for the SettingsCluster component, fulfilling the requirements from issue #4682 to increase test coverage from 0% to full visual documentation. The stories demonstrate the cluster settings form across various states including form interactions, data persistence, error handling, and validation scenarios.
Changes:
- Created SettingsCluster.stories.tsx with 11 story variants covering all major component states
- Implemented a clean localStorage setup pattern using a helper function
- Configured comprehensive mock Redux store to support all component dependencies
- Added clear JSDoc documentation for each story explaining its purpose
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9e4648b to
85901b9
Compare
85901b9 to
3ad7cab
Compare
Summary
This PR adds comprehensive Storybook coverage for the SettingsCluster, increasing test coverage from 0% to full visual documentation across all component states including cluster settings form, save operations, error handling, and validation scenarios.
Related Issue
Fixes #4682
Steps to Test