Skip to content

frontend: authchooser: expand auth flow stories#4713

Open
mahmoudmagdy1-1 wants to merge 1 commit intokubernetes-sigs:mainfrom
mahmoudmagdy1-1:auth-chooser-stories
Open

frontend: authchooser: expand auth flow stories#4713
mahmoudmagdy1-1 wants to merge 1 commit intokubernetes-sigs:mainfrom
mahmoudmagdy1-1:auth-chooser-stories

Conversation

@mahmoudmagdy1-1
Copy link
Contributor

Summary

This PR adds more AuthChooser story coverage by expanding auth flow states in Storybook.

Related Issue

Fixes #4685

Changes

  • Updated AuthChooser.stories.tsx with auth method selection, token-only, loading, failure, and redirect coverage states.
  • Added container-based auth failure and redirect stories with MSW.

Before:

-----------|---------|----------|---------|---------|-------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-----------|---------|----------|---------|---------|-------------------
All files  |     4.1 |       15 |   14.28 |     4.1 |                   
 index.tsx |     4.1 |       15 |   14.28 |     4.1 | 58-227            
-----------|---------|----------|---------|---------|-------------------

After:

-----------|---------|----------|---------|---------|---------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s         
-----------|---------|----------|---------|---------|---------------------------
All files  |   79.45 |    68.33 |   64.28 |   79.45 |                           
 index.tsx |   79.45 |    68.33 |   64.28 |   79.45 | 79-80,101,161-173,211-227 
-----------|---------|----------|---------|---------|---------------------------

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mahmoudmagdy1-1
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

2 participants