fix: parse milli-quantities in parseUnitsOfBytes by Pratikdeb07 · Pull Request #6817 · kubernetes-sigs/headlamp

Pratikdeb07 · 2026-08-02T19:22:35Z

Summary

This PR fixes an issue where memory usage percentages are displayed approximately 1000× larger than expected when the Metrics API returns memory quantities in milli-units (for example, 2687146666666m).

This occurs with prometheus-adapter, which commonly serves the metrics.k8s.io API in Prometheus-backed Kubernetes clusters that do not use metrics-server.

Related Issue

Fixes #6816

Changes

Added support for the Kubernetes m (milli) suffix in parseUnitsOfBytes() (frontend/src/lib/units.ts).
Parsed milli-byte values as parseFloat(value) / 1000, matching the existing handling in parseCpu().
Added unit tests covering milli-byte quantities, including:
- 1000m → 1
- 2687146666666m → 2687146666.666
- 1.5m → 0.0015

Steps to Test

Set up a cluster where the Metrics API is provided by prometheus-adapter (with resourceRules enabled) instead of metrics-server.
Open Cluster Overview.
- Verify memory usage displays approximately 32.8% (about 2.5 GiB / 7.63 GiB) instead of 32800%.
Open Workloads → Pods.
- Verify the CPU/Memory columns and the "Request: X%" tooltips display correct values.
Observe the UI for a few metrics refresh cycles.
- Memory usage should remain stable even when the metrics provider alternates between Ki and m quantity formats.

Screenshots

Before
Images are present in issue
After

Notes for Reviewers

N/A

Summary by CodeRabbit

Bug Fixes
- Improved memory quantity parsing for Kubernetes milli-unit values.
- Correctly handles whole, large, and fractional milli-quantities by converting them to base units.

kubernetes-prow · 2026-08-02T19:22:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pratikdeb07
Once this PR has been reviewed and has the lgtm label, please assign ashu8912 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

linux-foundation-easycla · 2026-08-02T19:22:43Z

The committers listed above are authorized under a signed CLA.

✅ login: Pratikdeb07 / name: Pratik Debnath (803320f)

kubernetes-prow · 2026-08-02T19:22:45Z

Welcome @Pratikdeb07!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

illume

Thanks for the contribution.

Could you take a look at the commit messages in this PR? We follow a Linux kernel style for git commits — see the contributing guide and git log for examples.

Commits that need attention

fix: parse milli-quantities in parseUnitsOfBytes — Missing area: description prefix — e.g. frontend: HomeButton: Fix so it navigates to home or backend: config: Add enable-dynamic-clusters flag.

Commit guidelines

Use atomic commits focused on a single change.
Use the title format <area>: <Description of changes> — description must start with a capital letter.
Keep the title under 72 characters (soft requirement).
Explain the intention and why the change is needed.
Make commit titles meaningful and describe what changed.
Do not add code that a later commit rewrites; squash or reorder commits instead.
Do not include Fixes #NN in commit messages.

Good examples:

frontend: HomeButton: Fix so it navigates to home
backend: config: Add enable-dynamic-clusters flag

Copilot

Pull request overview

This PR fixes incorrect memory usage/percentage calculations when the Kubernetes Metrics API returns milli-quantities for memory (e.g. values ending in m, as commonly emitted by prometheus-adapter). It updates the shared frontend unit parser so memory values remain consistent across refreshes even when the provider alternates between Ki and m formats.

Changes:

Add support for parsing byte quantities with the Kubernetes m (milli) suffix in parseUnitsOfBytes() by dividing by 1000.
Add unit tests validating milli-byte parsing behavior for typical and fractional inputs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
frontend/src/lib/units.ts	Adds explicit handling for `...m` byte quantities to prevent interpreting milli-values as raw bytes.
frontend/src/lib/units.test.ts	Adds coverage ensuring milli-byte quantities are parsed correctly and guard against regressions.

coderabbitai · 2026-08-05T17:49:45Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b8a60d01-d7e6-4f5c-9ebe-161d275c85a2

📥 Commits

Reviewing files that changed from the base of the PR and between ce115c8 and deec6d4.

📒 Files selected for processing (2)

frontend/src/lib/units.test.ts
frontend/src/lib/units.ts

🚧 Files skipped from review as they are similar to previous changes (2)

frontend/src/lib/units.test.ts
frontend/src/lib/units.ts

📝 Walkthrough

Walkthrough

The unit parser recognizes Kubernetes milli-quantity values and divides them by 1000 before existing byte-unit parsing. Tests cover integer, large, and fractional milli-quantity inputs.

Changes

Milli-quantity parsing

Layer / File(s)	Summary
Parse and validate milli-quantities `frontend/src/lib/units.ts`, `frontend/src/lib/units.test.ts`	`parseUnitsOfBytes` converts values ending in `m` to base units. `parseRam` tests cover integer, large, and fractional values.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: kahirokunn, skoeva, illume

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: parsing milli-quantities in parseUnitsOfBytes.
Description check	✅ Passed	The description includes the summary, issue, changes, testing steps, screenshots, and reviewer notes required by the template.
Linked Issues check	✅ Passed	The implementation and tests support issue `#6816` by parsing milli-byte quantities and preventing incorrect memory usage percentages.
Out of Scope Changes check	✅ Passed	The changes are limited to milli-quantity parsing and related unit tests, which directly match issue `#6816`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Pratikdeb07 · 2026-08-05T17:51:05Z

Thanks for your review @illume ! I have updated the commit message.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Signed-off-by: Pratik Debnath <pratikdebnath978@gmail.com>

coderabbitai · 2026-08-06T08:05:34Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

unlikelyzero

This only handles the 'm' suffix, but Kubernetes decimalSI also has 'u' (micro) and 'n' (nano) on the same family - same bug class, just less common. parseCpu right below in this same file already handles the full n/u/m ladder, and util.ts's normalizeUnit already handles all three for memory too, so the pattern to copy is already sitting in the codebase.

That duplication isn't theoretical either - resourceQuota/Details.tsx renders the same table row using both parsers: the Used/Hard columns go through normalizeUnit, and the Usage bar in that same row goes through parseRam/parseUnitsOfBytes. Before this PR they disagreed 1000x on milli values in that row; after it they agree on 'm' but still disagree on 'u'/'n' and on lowercase 'k' (which is the canonical k8s suffix - the regex here only matches uppercase 'K', so '1k' returns 1 instead of 1000, same 1000x bug in the same function).

A few smaller things inline.

unlikelyzero · 2026-08-13T03:31:58Z

+  // Milli-quantity ex. "2687146666666m". Valid Kubernetes quantity syntax
+  // (e.g. emitted by prometheus-adapter for memory usage), but no unit is
+  // matched by the regex below, which would misread it as raw bytes.
+  if (value.endsWith('m')) {


Would extend this to cover 'u' and 'n' too, mirroring parseCpu a few lines down: /1000 for m, /1e6 for u, /1e9 for n. Same bug, just needs two more branches.

unlikelyzero · 2026-08-13T03:31:58Z

+    return parseFloat(value) / 1000;
+  }
+
  const groups = value.match(/(\d+(?:\.\d+)?)([BKMGTPEe])?(i)?(\d+)?/) || [];


This character class only matches uppercase 'K', but the canonical Kubernetes suffix is lowercase 'k' (unlike M/G/T/P/E which are uppercase) - util.ts's normalizeUnit checks endsWith('k') for exactly this reason. Worth fixing while you're in here, since it's the same 1000x-off bug for the one suffix that happens to be lowercase.

unlikelyzero · 2026-08-13T03:31:58Z

    expect(parseRam('0.5G')).toBe(500000000);
  });

+  it('should parse milli quantities (e.g. from prometheus-adapter)', () => {


These test parseRam directly, but the actual reported bug is a percentage calculation through divideK8sResources - there's already a describe block for that with a comparable CPU nano/micro case a bit further down that this could extend with a memory-milli one.

kubernetes-prow · 2026-08-13T10:30:24Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

illume

Thanks for working on this.

Looks like there are git conflicts in this PR. Can you fix them up?

How to resolve conflicts

Rebase or merge the latest main into your branch, resolve the conflicts, and push the updated branch.

kubernetes-prow Bot requested review from kahirokunn and skoeva August 2, 2026 19:22

Pratikdeb07 force-pushed the fix/parse-milli-quantities branch from 803320f to 974aefb Compare August 3, 2026 03:17

skoeva added the frontend Issues related to the frontend label Aug 3, 2026

skoeva added this to the v0.45.0 milestone Aug 3, 2026

illume added kind/bug Categorizes issue or PR as related to a bug. testing labels Aug 5, 2026

illume requested a lite review from Copilot August 5, 2026 07:44

illume requested changes Aug 5, 2026

View reviewed changes

Copilot started reviewing on behalf of illume August 5, 2026 07:44 View session

Copilot AI reviewed Aug 5, 2026

View reviewed changes

Pratikdeb07 force-pushed the fix/parse-milli-quantities branch from 974aefb to c7e5770 Compare August 5, 2026 17:49

Pratikdeb07 requested a review from illume August 5, 2026 17:51

illume requested a lite review from Copilot August 5, 2026 18:11

Copilot started reviewing on behalf of illume August 5, 2026 18:11 View session

Copilot AI reviewed Aug 5, 2026

View reviewed changes

frontend: units: Parse milli-byte quantities in parseUnitsOfBytes

deec6d4

Signed-off-by: Pratik Debnath <pratikdebnath978@gmail.com>

Pratikdeb07 force-pushed the fix/parse-milli-quantities branch from c7e5770 to deec6d4 Compare August 6, 2026 08:05

illume requested a lite review from Copilot August 6, 2026 12:16

Copilot started reviewing on behalf of illume August 6, 2026 12:17 View session

Copilot AI reviewed Aug 6, 2026

View reviewed changes

This was referenced Aug 10, 2026

parseRam misreads the lowercase 'k' suffix, so 1k parses as 1 byte instead of 1000 #7072

Open

frontend: units: Parse the lowercase k suffix as kilo #7073

Open

unlikelyzero reviewed Aug 13, 2026

View reviewed changes

kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2026

illume requested changes Aug 13, 2026

View reviewed changes

Uh oh!

Conversation

Pratikdeb07 commented Aug 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Steps to Test

Screenshots

Notes for Reviewers

Summary by CodeRabbit

Uh oh!

kubernetes-prow Bot commented Aug 2, 2026

Uh oh!

linux-foundation-easycla Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubernetes-prow Bot commented Aug 2, 2026

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Pratikdeb07 commented Aug 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

coderabbitai Bot commented Aug 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

unlikelyzero left a comment

Choose a reason for hiding this comment

Uh oh!

unlikelyzero Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

unlikelyzero Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

unlikelyzero Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

kubernetes-prow Bot commented Aug 13, 2026

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Pratikdeb07 commented Aug 2, 2026 •

edited by coderabbitai Bot

Loading

linux-foundation-easycla Bot commented Aug 2, 2026 •

edited

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading