build: fix frontend lockfile and sync plugin dependencies - #7284
Open
Kakumanu-Harshitha wants to merge 1 commit into
Open
build: fix frontend lockfile and sync plugin dependencies#7284Kakumanu-Harshitha wants to merge 1 commit into
Kakumanu-Harshitha wants to merge 1 commit into
Conversation
kubernetes-prow
Bot
added
do-not-merge/invalid-commit-message
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kakumanu-Harshitha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Add @emnapi/core and @emnapi/runtime as direct dependencies in frontend to ensure they are correctly synced to the lockfile across different npm versions. Sync the same dependencies to the headlamp-plugin to prevent CI failures.
Kakumanu-Harshitha
force-pushed
the
fix-issue-7283
branch
from
August 16, 2026 12:26
934d690 to
60c9f73
Compare
kubernetes-prow
Bot
removed
the
do-not-merge/invalid-commit-message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
npm cilockfile parsing failures in the frontend CI workflows and subsequently fixes thetest-plugin-examplesCI job failure caused by the plugin dependencies falling out of sync.Related Issue
Fixes #7283
Changes
@emnapi/coreand@emnapi/runtimeas direct dependencies infrontend/package.jsonto ensure they are tracked properly across environments with different npm versions.frontend/package-lock.json.@emnapidependencies intoplugins/headlamp-plugin/package.json.plugins/headlamp-plugin/package-lock.jsonso the plugin tests pass cleanly during thedependencies-sync.jscheck.Steps to Test
git checkout fix-issue-7283.npm ciin thefrontend/directory and ensure it installs without the "Missing @emnapi" error.npm run check-dependenciesinsideplugins/headlamp-plugin/and ensure it exits with code 0 (no missing dependencies detected).test-plugin-examplesandfrontend-install-cijobs pass on this PR.Screenshots
N/A
Notes for the Reviewer
The original issue stemmed from transitive dependencies required by the frontend compiler changing between npm versions in CI vs local machines. By adding the
@emnapidependencies directly to the frontend, they get locked firmly in the lockfile for all environments. The plugin directory was then updated to mirror these changes and satisfy our dependency sync scripts.