frontend: ReleaseNotesModal: Make scrollable region focusable - #7290
Open
Saloni3494 wants to merge 1 commit into
Open
frontend: ReleaseNotesModal: Make scrollable region focusable#7290Saloni3494 wants to merge 1 commit into
Saloni3494 wants to merge 1 commit into
Conversation
This change adds tabIndex={0} to the DialogContent in ReleaseNotesModal.tsx. This fixes an accessibility issue where the scrollable region of the modal was not focusable by keyboard navigation, ensuring screen readers can access the content.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Saloni3494 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #7185 by ensuring the scrollable region inside the
ReleaseNotesModalis accessible via keyboard navigation. By addingtabIndex={0}to the<DialogContent>component, screen readers and keyboard-only users can now properly focus and scroll through the release notes.Related Issue
Fixes #7185
Changes
frontend/src/components/common/ReleaseNotes/ReleaseNotesModal.tsxtabIndex={0}toDialogContent.Steps to Test
npm run frontend:storybookcommon/ReleaseNotes/ReleaseNotesModal->Show.scrollable-region-focusableviolation no longer appears.Tabto navigate to the scrollable content area and use the arrow keys to scroll.Notes for the Reviewer
main, no conflicts.