Skip to content

Update transformers#336

Merged
SachinVarghese merged 1 commit intokubernetes-sigs:mainfrom
jjk-g:update-transformers
Feb 6, 2026
Merged

Update transformers#336
SachinVarghese merged 1 commit intokubernetes-sigs:mainfrom
jjk-g:update-transformers

Conversation

@jjk-g
Copy link
Collaborator

@jjk-g jjk-g commented Jan 30, 2026

Needed for newer model tokenizers (kimi 2.5)

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2026
@jjk-g jjk-g force-pushed the update-transformers branch from 7c2eb72 to 32e7d8d Compare January 31, 2026 00:41
@jjk-g
Copy link
Collaborator Author

jjk-g commented Feb 2, 2026

/hold

transformers 5.0.0 doesn't play nice with all tokenizers. will need to update this down to 4.57

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2026
@jjk-g jjk-g mentioned this pull request Feb 5, 2026
3 tasks
@jjk-g jjk-g force-pushed the update-transformers branch from 32e7d8d to 36b34a4 Compare February 5, 2026 23:59
@jjk-g
Copy link
Collaborator Author

jjk-g commented Feb 6, 2026

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2026
Updates pdm dependencies, infernece-perf version, and adds
tiktoken for kimi k2.5 support.
@jjk-g jjk-g force-pushed the update-transformers branch from 36b34a4 to d2be18c Compare February 6, 2026 18:34
Copy link
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjk-g, SachinVarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [SachinVarghese,jjk-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SachinVarghese SachinVarghese merged commit e3e690b into kubernetes-sigs:main Feb 6, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants