test(loadgen): add unit tests for worker concurrency distribution#337
Merged
jjk-g merged 1 commit intokubernetes-sigs:mainfrom Feb 15, 2026
Merged
test(loadgen): add unit tests for worker concurrency distribution#337jjk-g merged 1 commit intokubernetes-sigs:mainfrom
jjk-g merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Collaborator
|
Thanks for adding @sats-23! Can you please take a look at the linting and type checks |
Contributor
Author
Done, PTAL! |
Collaborator
|
Seems to still be hitting linting issues. Can reproduce locally with |
sats-23
force-pushed
the
issue325
branch
2 times, most recently
from
ccefe08 to
938469e
Compare
Add a new test suite to validate how LoadGenerator splits concurrency across workers. The tests cover evenly divisible cases, remainder handling, and scenarios where concurrency is lower than the number of workers. This also fixes Python 3.9 compatibility by replacing Type | None with Optional[Type], and adds lightweight test-time mocks for asyncio.TaskGroup and typing.TypeAlias so the suite runs cleanly on Python versions below 3.11. Signed-off-by: Sathvik <Sathvik.S@ibm.com>
Contributor
Author
CI is now passing, PTAL! |
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jjk-g, sats-23 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325
Add a new test suite to validate how LoadGenerator splits concurrency across workers.
The tests cover evenly
-divisible cases
-remainder handling
-concurrency lower than the number of workers
This also fixes Python 3.9 compatibility by replacing Type | None with Optional[Type], and adds lightweight test-time mocks for asyncio.TaskGroup and typing.TypeAlias so the suite runs cleanly on Python versions below 3.11.