feat(cloudprovider): add IBM disruption reasons#462
feat(cloudprovider): add IBM disruption reasons#462nekkunti wants to merge 3 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nekkunti The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@pfeifferj Could you review this . |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 55.77% 55.79% +0.02%
==========================================
Files 58 58
Lines 8757 8762 +5
==========================================
+ Hits 4884 4889 +5
Misses 3525 3525
Partials 348 348
🚀 New features to boost your workflow:
|
…drift feat: add subnet drift detection Signed-off-by: Anand Nekkunti <anand.nekkunti@ibm.com>
ad3b88b to
376f2f1
Compare
|
@pfeifferj merge conflict resolved , could you check this |
|
thank you @nekkunti I'll take a look either today or tomorrow |
|
there's a blocker upstream for this to be actually useful kubernetes-sigs/karpenter#2741 that's on me for not checking how this is implemented in core. I based #439 off the AWS provider which has the method but it's never called we can revisit this if upstream adds support for provider-defined disruption reasons |
Thanks , Please let me know once the upstream work is done, I’ll be happy to continue from there |
Description
Add IBM disruption reasons
Type of change
New feature / enhancement ( closes issue#439)