Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: RFC for NodeRegistrationHealthy Status Condition on NodePool #1910

Merged
merged 7 commits into from
Mar 7, 2025

Conversation

jigisha620
Copy link
Contributor

@jigisha620 jigisha620 commented Jan 10, 2025

Description

Adding RFC for NodeRegistrationHealthy Status Condition on NodePool

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jigisha620. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-rfc branch from 79262b2 to 1bc7741 Compare January 10, 2025 23:24
@coveralls
Copy link

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 13682752288

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 81.693%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 4 94.62%
Totals Coverage Status
Change from base Build 13666170746: -0.03%
Covered Lines: 9487
Relevant Lines: 11613

💛 - Coveralls

Copy link
Member

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkpointing

@jigisha620 jigisha620 force-pushed the degraded-nodepool-rfc branch from 1bc7741 to 3ffdbcc Compare January 14, 2025 23:41
@jigisha620 jigisha620 changed the title WIP: RFC for Degraded NodePool Status Condition RFC for Degraded NodePool Status Condition Jan 16, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-rfc branch 3 times, most recently from 165d44a to 06d7cb2 Compare February 13, 2025 01:24
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-rfc branch from 06d7cb2 to d663fcf Compare February 13, 2025 01:51
@jigisha620 jigisha620 force-pushed the degraded-nodepool-rfc branch 2 times, most recently from 2b217ff to 01499e4 Compare March 3, 2025 20:34
@jigisha620 jigisha620 changed the title RFC for Degraded NodePool Status Condition chore: RFC for Degraded NodePool Status Condition Mar 3, 2025
@jigisha620 jigisha620 changed the title chore: RFC for Degraded NodePool Status Condition chore: RFC for NodeRegistrationHealthy Status Condition on NodePool Mar 5, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-rfc branch from 01499e4 to 9fc8540 Compare March 5, 2025 18:17
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jigisha620, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7fd1af5 into kubernetes-sigs:main Mar 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants