-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: RFC for NodeRegistrationHealthy Status Condition on NodePool #1910
chore: RFC for NodeRegistrationHealthy Status Condition on NodePool #1910
Conversation
Hi @jigisha620. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
79262b2
to
1bc7741
Compare
Pull Request Test Coverage Report for Build 13682752288Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checkpointing
1bc7741
to
3ffdbcc
Compare
165d44a
to
06d7cb2
Compare
06d7cb2
to
d663fcf
Compare
2b217ff
to
01499e4
Compare
01499e4
to
9fc8540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jigisha620, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adding RFC for NodeRegistrationHealthy Status Condition on NodePool
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.