-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NodeRegistrationHealthy status condition to nodepool #1969
feat: add NodeRegistrationHealthy status condition to nodepool #1969
Conversation
Hi @jigisha620. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull Request Test Coverage Report for Build 13682775160Details
💛 - Coveralls |
d060e31
to
659e4dd
Compare
03a7d60
to
3fd43cf
Compare
3fd43cf
to
d202c66
Compare
5df485a
to
67ea6d0
Compare
bc920ec
to
7f356d4
Compare
7f356d4
to
a9d685a
Compare
a9d685a
to
810ad69
Compare
810ad69
to
30a813f
Compare
30a813f
to
deab154
Compare
deab154
to
0df5fb4
Compare
0df5fb4
to
9cb2a9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jigisha620, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
This PR adds
NodeRegistrationHealthy
status condition to nodePool which indicates if a misconfiguration exists that is preventing successful node launch/registrations that requires manual investigation.How was this change tested?
Added tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.