Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NodeRegistrationHealthy status condition to nodepool #1969

Merged

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
This PR adds NodeRegistrationHealthy status condition to nodePool which indicates if a misconfiguration exists that is preventing successful node launch/registrations that requires manual investigation.

How was this change tested?
Added tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jigisha620. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2025
@coveralls
Copy link

coveralls commented Feb 6, 2025

Pull Request Test Coverage Report for Build 13682775160

Details

  • 117 of 154 (75.97%) changed or added relevant lines in 9 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 81.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/test/v1alpha1/zz_generated.deepcopy.go 9 16 56.25%
pkg/controllers/nodeclaim/lifecycle/liveness.go 17 25 68.0%
pkg/controllers/nodeclaim/lifecycle/registration.go 13 21 61.9%
pkg/controllers/nodepool/registrationhealth/controller.go 31 44 70.45%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.66%
Totals Coverage Status
Change from base Build 13666170746: -0.1%
Covered Lines: 9594
Relevant Lines: 11755

💛 - Coveralls

@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch 4 times, most recently from d060e31 to 659e4dd Compare February 6, 2025 22:28
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch 2 times, most recently from 03a7d60 to 3fd43cf Compare February 12, 2025 02:13
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from 3fd43cf to d202c66 Compare February 12, 2025 19:05
@jigisha620 jigisha620 changed the title chore: add NodeRegistrationHealthy status condition to nodepool feat: add NodeRegistrationHealthy status condition to nodepool Feb 12, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch 3 times, most recently from 5df485a to 67ea6d0 Compare February 12, 2025 22:09
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from bc920ec to 7f356d4 Compare February 13, 2025 21:52
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from 7f356d4 to a9d685a Compare February 17, 2025 20:48
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 17, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from a9d685a to 810ad69 Compare February 20, 2025 00:28
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from 810ad69 to 30a813f Compare February 26, 2025 20:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2025
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from 30a813f to deab154 Compare February 26, 2025 21:40
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from deab154 to 0df5fb4 Compare March 5, 2025 01:55
@jigisha620 jigisha620 force-pushed the degraded-nodepool-implementation branch from 0df5fb4 to 9cb2a9b Compare March 5, 2025 18:19
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jigisha620, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit af2b998 into kubernetes-sigs:main Mar 5, 2025
14 checks passed
DerekFrank pushed a commit to DerekFrank/karpenter-testing-fork that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants