fix(nodeclaim): dedup logs marking consolidatable

[flavono123]

Fixes #2002

Description

after set a nodeclaim is consolidatable, pause a while for a node handler does not work duplicated jobs

How was this change tested?

no, but guess it works since there are other cases referenced

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Hi @flavono123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coveralls]

Pull Request Test Coverage Report for Build 14258446430

Details

• 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
• 13 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.08%) to 81.601%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/test/cachesyncingclient.go	2	84.38%
pkg/utils/termination/termination.go	2	88.24%
pkg/controllers/provisioning/scheduling/topologydomaingroup.go	4	86.21%
pkg/controllers/node/termination/controller.go	5	69.54%

Totals
Change from base Build 14255724831:	-0.08%
Covered Lines:	9713
Relevant Lines:	11903

---

💛 - Coveralls

[jonathan-innis]

I think we should only sleep if the condition has changed. Otherwise, we risk sleeping on every iteration

[jonathan-innis]

So, this sleep here isn't actually going to do anything. The sleep needs to come after the Patch to give the cache time to update. If we just sleep here without doing a cache update, we aren't really accomplishing the deduping that we intended

[flavono123]

i did change following how lifecycle controller does, you mentioned in the issue, but not sure not duplicating logs

[engedaam]

/assign @jonathan-innis

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flavono123
Once this PR has been reviewed and has the lgtm label, please ask for approval from jonathan-innis. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jonathan-innis]

I get that we are doing this in the lifecycle controller but looking back at this change, this sleep actually makes me a tad nervous about performance. Given that we only have 10 async threads occurring at one time, this has the potential to drastically slow down the performance of this controller.

I wonder if a better option here is to create some caching mechanism for the controller where we track how recently a key has been seen and processed and then avoid re-processing that key within a certain amount of time since we know that we just processed it

[flavono123]

added *cache.Cache for the controller by referencing the consistency controller does https://github.com/kubernetes-sigs/karpenter/blob/main/pkg/controllers/nodeclaim/consistency/controller.go#L52

plz check the dedupe time window should be tuned

[flavono123]

make verify works on my local machine. no idea why the error is on ci