Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unschedulable_pods_count metric in disruption loop #2049

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove unschedulable_pods_count metric in disruption loop #2049

wants to merge 1 commit into from

Conversation

jxs1211
Copy link

@jxs1211 jxs1211 commented Mar 4, 2025 •
edited
Loading

Fixes #1993
Description
remove the unschedulable_pods_count metric if the controller is not provisioner

How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jxs1211
Once this PR has been reviewed and has the lgtm label, please assign tzneal for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jxs1211. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2025
@jxs1211 jxs1211 changed the title remove unschedulable_pods_count metric in disruption loop fix:remove unschedulable_pods_count metric in disruption loop Mar 4, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13643985159

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 81.637%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 95.0%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.52%
Totals Coverage Status
Change from base Build 13641140264: -0.08%
Covered Lines: 9474
Relevant Lines: 11605
💛 - Coveralls

@jxs1211 jxs1211 changed the title fix:remove unschedulable_pods_count metric in disruption loop fix: remove unschedulable_pods_count metric in disruption loop Mar 4, 2025
jonathan-innis
jonathan-innis reviewed Mar 4, 2025
View reviewed changes
pkg/controllers/provisioning/scheduling/scheduler.go
@@ -275,7 +275,9 @@ func (s *Scheduler) Solve(ctx context.Context, pods []*corev1.Pod) Results {
// We need to schedule them alternating, A, B, A, B, .... and this solution also solves that as well.
errors := map[*corev1.Pod]error{}
// Reset the metric for the controller, so we don't keep old ids around
UnschedulablePodsCount.DeletePartialMatch(map[string]string{ControllerLabel: injection.GetControllerName(ctx)})
if injection.GetControllerName(ctx) == "provisioner" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just drop deleting this altogether? It's not clear to me why we just don't rely on the next round of scheduling to handle it -- the one thing that we do need to handle is setting the value to 0 when we don't find any pending pods/when we aren't getting a trigger to run scheduling.

jonathan-innis
jonathan-innis reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than deleting the metric, I'd like to just see us setting it to 0

@jonathan-innis jonathan-innis mentioned this pull request Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@engedaam engedaam Awaiting requested review from engedaam

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

karpenter_scheduler_unschedulable_pods_count has unnecessary DeletePartialMatch in the scheduler
4 participants
@jxs1211 @k8s-ci-robot @coveralls @jonathan-innis