Skip to content

feat(nodeclaim): use PodScheduled's status for lastPodEventTime #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flavono123
Copy link
Contributor

Fixes #1965

Description

use PodScheduled's lastTransitionTime for NodeClaim.LastPodEventTime
actually, only for the pod is bound to node so it still has same timestamp value for terminal and terminating
(should we follow deletionTimestamp or some risks are if then?)
the mitigations by dedupeTimestamp are removed
filter for registering more precise only for the PodScheduled has changed

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @flavono123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2025
@coveralls
Copy link

coveralls commented Mar 5, 2025

Pull Request Test Coverage Report for Build 15176079615

Details

  • 19 of 31 (61.29%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 81.918%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/podevents/controller.go 18 30 60.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 85.55%
pkg/controllers/provisioning/scheduling/preferences.go 7 88.76%
Totals Coverage Status
Change from base Build 15175060207: -0.07%
Covered Lines: 10189
Relevant Lines: 12438

💛 - Coveralls

@jonathan-innis
Copy link
Member

/assign @jonathan-innis

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2025
@flavono123 flavono123 marked this pull request as draft April 1, 2025 00:03
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@flavono123 flavono123 force-pushed the fix/remove-pod-event-time-cache branch from f01f7dd to 00a47ad Compare April 2, 2025 00:59
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flavono123
Once this PR has been reviewed and has the lgtm label, please ask for approval from jonathan-innis. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@flavono123 flavono123 force-pushed the fix/remove-pod-event-time-cache branch 4 times, most recently from ddeaccd to dca7a2c Compare April 2, 2025 07:34
@flavono123 flavono123 marked this pull request as ready for review April 2, 2025 07:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from engedaam April 2, 2025 07:49
@flavono123
Copy link
Contributor Author

return reconcile.Result{}, nil
}

// otherwise, set the pod event time to now
stored := nc.DeepCopy()
nc.Status.LastPodEventTime.Time = c.clock.Now()

nc.Status.LastPodEventTime.Time = eventTime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be max otherwise it's going to oscillate around as different pods get reconciled. Also, I think still applying a dedupe timeout makes sense -- basically, if the current stored time is within (say 10s) of the new time, then don't update it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ammended

@jonathan-innis
Copy link
Member

@flavono123 Just checking in on this one!

@flavono123 flavono123 force-pushed the fix/remove-pod-event-time-cache branch from c9eca31 to a34f011 Compare May 21, 2025 08:55
@flavono123 flavono123 requested a review from jonathan-innis May 21, 2025 13:50
@flavono123 flavono123 force-pushed the fix/remove-pod-event-time-cache branch from a9f4b2f to 0abe1eb Compare May 22, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod events controllers should use PodScheduled's lastTransitionTime to mark when pod events occur
4 participants