-
Notifications
You must be signed in to change notification settings - Fork 283
feat(nodeclaim): use PodScheduled's status for lastPodEventTime #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(nodeclaim): use PodScheduled's status for lastPodEventTime #2054
Conversation
Hi @flavono123. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull Request Test Coverage Report for Build 15176079615Details
💛 - Coveralls |
/assign @jonathan-innis |
f01f7dd
to
00a47ad
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavono123 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ddeaccd
to
dca7a2c
Compare
https://github.com/kubernetes-sigs/karpenter/actions/runs/14214081694/job/39826657535?pr=2054#step:5:642 |
return reconcile.Result{}, nil | ||
} | ||
|
||
// otherwise, set the pod event time to now | ||
stored := nc.DeepCopy() | ||
nc.Status.LastPodEventTime.Time = c.clock.Now() | ||
|
||
nc.Status.LastPodEventTime.Time = eventTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be max otherwise it's going to oscillate around as different pods get reconciled. Also, I think still applying a dedupe timeout makes sense -- basically, if the current stored time is within (say 10s) of the new time, then don't update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ammended
@flavono123 Just checking in on this one! |
c9eca31
to
a34f011
Compare
…ntTime when pod is bound Signed-off-by: flavono123 <[email protected]>
…out or is max Signed-off-by: flavono123 <[email protected]>
a9f4b2f
to
0abe1eb
Compare
Fixes #1965
Description
use PodScheduled's lastTransitionTime for NodeClaim.LastPodEventTime
actually, only for the pod is bound to node so it still has same timestamp value for terminal and terminating
(should we follow deletionTimestamp or some risks are if then?)
the mitigations by dedupeTimestamp are removed
filter for registering more precise only for the PodScheduled has changed
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.