Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote jmdeal to maintainer #2057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmdeal
Copy link
Member

@jmdeal jmdeal commented Mar 7, 2025

Fixes #N/A

Description
Opening a request to promote myself from karpenter-reviewer to karpenter-maintainer. I've been an active contributor / reviewer both here and in the AWS provider for the past ~1.5 years and have been a reviewer since this project was donated to kubernetes-sigs.

Contributions: https://github.com/kubernetes-sigs/karpenter/pulls?page=1&q=is%3Apr+author%3Ajmdeal+is%3Aclosed
Reviews: https://github.com/kubernetes-sigs/karpenter/pulls?q=is%3Apr+assignee%3Ajmdeal+is%3Aclosed

How was this change tested?
N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmdeal
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13710923658

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 81.582%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/topologydomaingroup.go 4 86.21%
Totals Coverage Status
Change from base Build 13683176482: -0.03%
Covered Lines: 9590
Relevant Lines: 11755

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants