Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add cleanup section to the contributor ladder doc #2062

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

Adds a section to the contributor ladder doc on the process for removing reviewers and moving approvers to emiritus

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from engedaam and jmdeal March 7, 2025 19:16
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2025
@coveralls
Copy link

coveralls commented Mar 7, 2025

Pull Request Test Coverage Report for Build 13727726084

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 81.593%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 95.0%
pkg/controllers/disruption/consolidation.go 4 85.55%
Totals Coverage Status
Change from base Build 13727397084: -0.05%
Covered Lines: 9597
Relevant Lines: 11762

💛 - Coveralls

@jmdeal
Copy link
Member

jmdeal commented Mar 7, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 866c96b into kubernetes-sigs:main Mar 7, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants