Skip to content

Conversation

@moko-poi
Copy link
Contributor

Fixes #2238

Description

Adds detailed structured logging to ValidatePodsDisruptable() to help operators understand why nodes cannot be consolidated.

Previously, Karpenter would loop with generic "marking/removing consolidatable" messages when a node couldn't be consolidated. Now it logs specific details:

  • Which pod is blocking consolidation
  • The blocking reason (do-not-disrupt annotation or PDB violation)
  • Which PDB is preventing eviction
  • List of affected pods for PDB violations

Example output:

cannot consolidate node, PDB prevents eviction
  node="ip-10-0-1-100"
  pods=["default/mysql-0"]
  pdb="default/mysql-pdb"
  reason="pdb-blocks-eviction"

How was this change tested?

Verified compilation and existing tests pass. The change only adds logging without modifying behavior.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Hi @moko-poi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: moko-poi
Once this PR has been reviewed and has the lgtm label, please assign jmdeal for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19798868290

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 80.277%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/static/provisioning/controller.go 2 58.54%
pkg/controllers/disruption/consolidation.go 4 88.0%
pkg/controllers/provisioning/scheduling/preferences.go 7 88.76%
Totals Coverage Status
Change from base Build 19683853291: -0.03%
Covered Lines: 11877
Relevant Lines: 14795

💛 - Coveralls

@moko-poi
Copy link
Contributor Author

Hi @mwielgus @tallaxes,
Could you please take a look at this PR when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more context to "removing consolidatable status condition" message

3 participants