Skip to content

Conversation

@ryan-mist
Copy link
Contributor

@ryan-mist ryan-mist commented Dec 11, 2025

Fixes #N/A

Description

  • add minDrainTime to termination flow to ensure pods scheduled immediately after the taint is applied will still be drained

How was this change tested?

  • make presubmit
  • manual testing to ensure minDrainTime has passed before node termination

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ryan-mist
Once this PR has been reviewed and has the lgtm label, please assign tzneal for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @ryan-mist. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2025
@coveralls
Copy link

coveralls commented Dec 15, 2025

Pull Request Test Coverage Report for Build 20382512924

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 63 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 80.323%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/state/informer/nodeclaim.go 9 68.57%
pkg/controllers/nodeclaim/lifecycle/controller.go 21 71.74%
pkg/state/cost/cost.go 33 74.55%
Totals Coverage Status
Change from base Build 20243170426: 0.02%
Covered Lines: 11871
Relevant Lines: 14779

💛 - Coveralls

@ryan-mist ryan-mist changed the title [Draft] chore: add minDrainTime chore: add minDrainTime Dec 15, 2025
@ryan-mist ryan-mist marked this pull request as ready for review December 15, 2025 21:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2025
@ryan-mist ryan-mist marked this pull request as draft December 15, 2025 22:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2025
@ryan-mist ryan-mist force-pushed the min-drain-time branch 6 times, most recently from 5c0dff7 to 4b9fafd Compare December 16, 2025 01:40
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 16, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2025
@ryan-mist ryan-mist force-pushed the min-drain-time branch 3 times, most recently from 2350afc to 844cef6 Compare December 16, 2025 04:11
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2025
@ryan-mist ryan-mist marked this pull request as ready for review December 16, 2025 05:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2025
Copy link
Member

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants