feat(vpa): thread prediction store through disruption path - #3235
Open
jigisha620 wants to merge 1 commit into
Open
feat(vpa): thread prediction store through disruption path#3235jigisha620 wants to merge 1 commit into
jigisha620 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jigisha620 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jigisha620
force-pushed
the
feat/vpa-disruption-integration
branch
from
August 17, 2026 18:08
f0d07a5 to
2e06a59
Compare
jigisha620
force-pushed
the
feat/vpa-disruption-integration
branch
from
August 25, 2026 21:10
2e06a59 to
c54c0fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Threads the VPA prediction store through the disruption path so that consolidation and drift use predicted post-eviction resource requests instead of current ones. When a VPA recommends higher (or lower) resources for a workload, Karpenter now accounts for what the pod will actually request after recreation rather than what it currently has.
Changes
How was this change tested?
Added unit tests for PredictedRequests covering all owner resolution paths, multi-container pods, partial predictions,
and new resource injection. Added disruption integration tests covering consolidation blocked/enabled by predictions, DaemonSet overhead predictions, partial predictions, lower-than-current predictions, and drift replacement sizing.
Tested on a live cluster with a NodePool allowing
c5.xlarge(4 CPU) andc5.large(2 CPU). Consolidation attempts to replace underutilized c5.xlarge nodes with cheaper c5.large nodes.AI Disclosure: This PR was developed with AI assistance. Per the project's AI contribution policy, this is disclosed here. I have reviewed and tested all the code .