POC prefer m/r/x types if new pods have high memory requests - #3241
Draft
grosser wants to merge 1 commit into
Draft
POC prefer m/r/x types if new pods have high memory requests#3241grosser wants to merge 1 commit into
grosser wants to merge 1 commit into
Conversation
grosser
marked this pull request as draft
August 17, 2026 22:40
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: grosser The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
our nodepools ended up always spinning up m or c types (cheapest) since the pendings pods were never big enough to require r types (we run 8xl as the smallest ~30 cpus) so we ended up with lots of c/m-s but the actual pod requests were very memory heavy so we had to wait for consolidation which lead to more pod interruptions
(also tried changing batching settings, but even 1m/5m did not help)
How was this change tested?
updated the nodepool and saw that we get a good mix of m and r on the first try now
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.