Skip to content

fix: skip provisioning pods already claimed by healthy in-flight NodeClaims - #3243

Open
aardbol wants to merge 3 commits into
kubernetes-sigs:mainfrom
aardbol:fix/3121
Open

fix: skip provisioning pods already claimed by healthy in-flight NodeClaims#3243
aardbol wants to merge 3 commits into
kubernetes-sigs:mainfrom
aardbol:fix/3121

Conversation

@aardbol

@aardbol aardbol commented Aug 18, 2026

Copy link
Copy Markdown

Fixes #3121

Description

Karpenter was launching duplicate NodeClaims for the same pending pods while their first NodeClaim was still in-flight (not yet registered/initialized). The pod→NodeClaim mapping existed but was only used for metrics. GetPendingPods now skips pods already claimed by a healthy in-flight NodeClaim, and releases them when that claim goes away (deleted, terminating, launch/registration timeout, or initialized), so no excess nodes are launched during the registration window.

How was this change tested?

  • Added regression coverage in pkg/controllers/provisioning/suite_test.go:
    • pod claimed by a healthy in-flight NodeClaim is excluded from GetPendingPods
    • mapping/pod released on NodeClaim deletion, terminating, launch timeout, registration timeout, and initialization
    • stale mapping dropped on missing NodeClaim without resetting metric state
  • End-to-end verification (with https://github.com/upcloud-tools/karpenter-provider-upcloud):
    • 1 concurrent pod → 1 NodeClaim (previously 2)
    • 3 simultaneous pods → 1 NodeClaim, all pods Running
    • no duplicate NodeClaims across multiple reconciliation loops spanning the node-registration window

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 18, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: aardbol / name: aardbol (af20081)

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aardbol
Once this PR has been reviewed and has the lgtm label, please assign engedaam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Welcome @aardbol!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 18, 2026
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provisioner creates excess NodeClaims for simultaneously pending pods even without topology constraints

1 participant