Skip to content

feat: RFC for disruption performance metrics - #3255

Draft
GnatorX wants to merge 1 commit into
kubernetes-sigs:mainfrom
GnatorX:garvinp/disruption-perf-metrics-rfc
Draft

feat: RFC for disruption performance metrics#3255
GnatorX wants to merge 1 commit into
kubernetes-sigs:mainfrom
GnatorX:garvinp/disruption-perf-metrics-rfc

Conversation

@GnatorX

@GnatorX GnatorX commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #N/A

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kubernetes-prow kubernetes-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GnatorX
Once this PR has been reviewed and has the lgtm label, please assign derekfrank for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from mwielgus and tallaxes August 21, 2026 20:59
@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2026
@GnatorX GnatorX changed the title feat: RFC for per metrics feat: RFC for disruption performance metrics Aug 24, 2026

| Metric | Type | Labels | Meaning |
|---|---|---|---|
| passes_total | Counter | nodepool, reason, consolidation_type, outcome | Completed method passes: no_candidates, no_command, selected, timed_out, or error. |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly, I'd ship these without an RFC, we can always deprecate metrics :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants