Skip to content

feat: support DRA admin access in the device allocator - #3266

Open
yindia wants to merge 2 commits into
kubernetes-sigs:mainfrom
yindia:dra-admin-access
Open

feat: support DRA admin access in the device allocator#3266
yindia wants to merge 2 commits into
kubernetes-sigs:mainfrom
yindia:dra-admin-access

Conversation

@yindia

@yindia yindia commented Aug 26, 2026

Copy link
Copy Markdown

Fixes #3230

Description

Admin-access ResourceClaim requests (KEP-5018) can bind to devices that are already allocated and do not consume them. This wires that behavior into the device allocator:

  • Admin-access requests treat already-allocated devices as eligible placement options, instead of skipping them.
  • Admin-access allocations no longer count as consuming a device, so other claims can still use it.
  • Existing admin-access allocations read from the cluster are ignored the same way.

As a result, Karpenter does not provision extra nodes for admin-access pods that fit hardware already in use.

How was this change tested?

  • Allocator unit tests: bind to allocated devices, ignore counters and capacity, and keep device distinctness and selector matching.
  • deviceallocation controller unit tests: skip admin-access results.
  • Provisioning integration tests: an admin-access pod binds to a held device on an existing node with no new NodeClaim, while an equivalent normal claim launches one.
  • go test ./pkg/scheduling/dynamicresources/... ./pkg/controllers/dynamicresources/... ./pkg/controllers/provisioning/... on envtest 1.35. Pre-existing Consumable Capacity failures are unrelated; they need the DRAConsumableCapacity apiserver feature gate.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yindia
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Welcome @yindia!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DRA KEP 5018: Admin Access

1 participant