Skip to content

Conversation

@BenTheElder
Copy link
Member

now that kubernetes 1.33 is out and the post-thaw merge queue is drained ...

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2025
@BenTheElder BenTheElder force-pushed the bump-containerd-runc branch from dcac750 to e49a49d Compare April 24, 2025 05:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2025
@BenTheElder
Copy link
Member Author

hmmm the actions jobs are having issues, we might actually have a regression in here

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
@BenTheElder
Copy link
Member Author

ehhh they're also broken on the empty PR: #648

I would like to see them passing though ...

@BenTheElder
Copy link
Member Author

will have to rebase with #3921, which will annoyingly make the base image not match a commit anymore >.>

maybe just adding that as a new commit here ...

@BenTheElder
Copy link
Member Author

ok the node image passed on all of the GHA now

@BenTheElder BenTheElder force-pushed the bump-containerd-runc branch from 7acf149 to 8950d6c Compare April 25, 2025 00:44
@BenTheElder BenTheElder changed the title WIP: bump go, containerd, runc bump go, containerd, runc Apr 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2025
@aojea
Copy link
Contributor

aojea commented Apr 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@BenTheElder
Copy link
Member Author

/hold-cancel

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 84e9c79 into kubernetes-sigs:main Apr 25, 2025
31 checks passed
@BenTheElder BenTheElder deleted the bump-containerd-runc branch April 25, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants