-
Notifications
You must be signed in to change notification settings - Fork 1.7k
updating all images to latest #4069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
we could update again with #3965 but I think it's not critical |
|
|
||
| // Image defines the loadbalancer image:tag | ||
| const Image = "docker.io/kindest/haproxy:v20230606-42a2262b" | ||
| const Image = "docker.io/kindest/haproxy:v20251211-v0.29.0-alpha-100-g82a92c5d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smoke tested locally, seems fine.
$ cat $HOME/kind-ha.yaml
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
- role: control-plane
- role: control-plane
$ kind create cluster --config=$HOME/kind-ha.yaml
Creating cluster "kind" ...
✓ Ensuring node image (kindest/node:v1.34.2) 🖼
✓ Preparing nodes 📦 📦 📦
✓ Configuring the external load balancer ⚖️
✓ Writing configuration 📜
✓ Starting control-plane 🕹️
✓ Installing CNI 🔌
✓ Installing StorageClass 💾
✓ Joining more control-plane nodes 🎮
Set kubectl context to "kind-kind"
You can now use your cluster with:
kubectl cluster-info --context kind-kind
Not sure what to do next? 😅 Check out https://kind.sigs.k8s.io/docs/user/quick-start/
$ kubectl get po -A
NAMESPACE NAME READY STATUS RESTARTS AGE
kube-system coredns-66bc5c9577-26ct8 1/1 Running 0 50s
kube-system coredns-66bc5c9577-sw2p8 1/1 Running 0 50s
kube-system etcd-kind-control-plane 1/1 Running 0 58s
kube-system etcd-kind-control-plane2 1/1 Running 0 24s
kube-system etcd-kind-control-plane3 1/1 Running 0 14s
kube-system kindnet-86km5 1/1 Running 0 16s
kube-system kindnet-qnkn8 1/1 Running 0 26s
kube-system kindnet-xks7f 1/1 Running 0 50s
kube-system kube-apiserver-kind-control-plane 1/1 Running 0 58s
kube-system kube-apiserver-kind-control-plane2 1/1 Running 0 24s
kube-system kube-apiserver-kind-control-plane3 1/1 Running 0 14s
kube-system kube-controller-manager-kind-control-plane 1/1 Running 0 58s
kube-system kube-controller-manager-kind-control-plane2 1/1 Running 0 24s
kube-system kube-controller-manager-kind-control-plane3 1/1 Running 0 14s
kube-system kube-proxy-f6mvv 1/1 Running 0 26s
kube-system kube-proxy-s4nj7 1/1 Running 0 16s
kube-system kube-proxy-vvtk5 1/1 Running 0 50s
kube-system kube-scheduler-kind-control-plane 1/1 Running 0 58s
kube-system kube-scheduler-kind-control-plane2 1/1 Running 0 24s
kube-system kube-scheduler-kind-control-plane3 1/1 Running 0 14s
local-path-storage local-path-provisioner-5c4cdb564f-cfbcj 1/1 Running 0 49s|
/lgtm |
|
@BenTheElder: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Ah, that's going to be a problem ... |
|
Only 1.33 is impacted, we can consider something like configuring CI to skip these tests on 1.33, but we need to discuss in kubernetes/kubernetes#135214 |
|
|
||
| // Image is the default for the Config.Image field, aka the default node image. | ||
| const Image = "kindest/node:v1.34.0@sha256:7416a61b42b1662ca6ca89f02028ac133a309a2a30ba309614e8ec94d976dc5a" | ||
| const Image = "kindest/node:v1.34.2@sha256:745f8ed46d8e99517774768227fd1a0af34a6bf395aef9c7ed98fbce0e263918" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should do 1.34.3
picks up assorted updates ahead of v0.31.0