Skip to content

Update to Go 1.25#40

Merged
aojea merged 5 commits intokubernetes-sigs:mainfrom
Tjaarda1:go125-ci
Jan 23, 2026
Merged

Update to Go 1.25#40
aojea merged 5 commits intokubernetes-sigs:mainfrom
Tjaarda1:go125-ci

Conversation

@Tjaarda1
Copy link
Contributor

@Tjaarda1 Tjaarda1 commented Jan 20, 2026

Update repository baseline to go 1.25
Update gha workflows to use go 1.25 for unit/verify and e2e build.

Fixes #39

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 20, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 20, 2026

Welcome @Tjaarda1!

It looks like this is your first PR to kubernetes-sigs/kindnet 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kindnet has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from aojea January 20, 2026 19:28
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 20, 2026
@k8s-ci-robot k8s-ci-robot requested a review from thockin January 20, 2026 19:28
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 20, 2026

Hi @Tjaarda1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 20, 2026
@Tjaarda1 Tjaarda1 marked this pull request as draft January 20, 2026 19:44
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@Tjaarda1
migrate golangci-lint config to v2 per migration guide
482257f 
The change follows the official migration guide: it adds version: 2, replaces disable-all with linters.default: none, removes merged linters (gosimple, stylecheck, typecheck are now part of staticheck), as required in v2.
@Tjaarda1
Copy link
Contributor Author

Tjaarda1 commented Jan 20, 2026

Golangci-lint v2.7.2 introduces additional findings (primarily errcheck on unchecked Close() calls and one govet IPv6 host:port issue). I am currently addressing these while keeping the lint policy unchanged.

@aojea
Copy link
Contributor

aojea commented Jan 20, 2026

great

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2026
aojea
aojea reviewed Jan 20, 2026
View reviewed changes
@aojea
Copy link
Contributor

aojea commented Jan 20, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2026
aojea
aojea reviewed Jan 21, 2026
View reviewed changes
pkg/nat64/proxy.go
// https://www.rfc-editor.org/rfc/rfc6052.html
ip4 := ip4in6[12:16]
dstV4Addr := fmt.Sprintf("%s:%d", ip4.String(), dstAddr.Port)
dstV4Addr := net.JoinHostPort(ip4.String(), strconv.Itoa(dstAddr.Port))
Copy link
Contributor

@aojea aojea Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, this ip is always ipv4, it is fine to change it so we keep the linter happy, but previous was correct too

Copy link
Contributor Author

@Tjaarda1 Tjaarda1 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed!

@aojea
Copy link
Contributor

aojea commented Jan 21, 2026

Thanks for your work @Tjaarda1 , it seems this is ready for review, tests are passing, are you expecting to do more changes?
Otherwise just undraft it

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, Tjaarda1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026
@Tjaarda1 Tjaarda1 marked this pull request as ready for review January 21, 2026 17:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2026
@stmcginnis
Copy link
Contributor

stmcginnis commented Jan 22, 2026

/retest

@aojea aojea merged commit 947d4c2 into kubernetes-sigs:main Jan 23, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin Awaiting requested review from thockin

@aojea aojea Awaiting requested review from aojea

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update kindnet to golang 1.25

4 participants

@Tjaarda1 @k8s-ci-robot @aojea @stmcginnis