Skip to content

Fixed Panic in Production Code - Graph Builder #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnshulPatil2005 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fixed Panic in Production Code - Graph Builder #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/graph/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,8 +949,11 @@ func getSchemaWithoutStatus(crd *extv1.CustomResourceDefinition) (*spec.Schema,
crdCopy := crd.DeepCopy()

// TODO(a-hilaly) expand this function when we start support CRD upgrades.
if len(crdCopy.Spec.Versions) != 1 || crdCopy.Spec.Versions[0].Schema == nil {
panic("Expected CRD to have exactly one version with schema defined")
if len(crdCopy.Spec.Versions) != 1 {
return nil, fmt.Errorf("expected CRD to have exactly one version, got %d versions: multi-version CRDs not yet supported", len(crdCopy.Spec.Versions))
}
if crdCopy.Spec.Versions[0].Schema == nil {
return nil, fmt.Errorf("expected CRD version to have schema defined, but schema is nil")
}

openAPISchema := crdCopy.Spec.Versions[0].Schema.OpenAPIV3Schema
Expand Down