-
Notifications
You must be signed in to change notification settings - Fork 83
feat: nested manifests in object transforms #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nested manifests in object transforms #397
Conversation
Hi @sdowell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @justinsb |
This change adds support for applying object transforms to nested manifests. The nested manifest pattern is a pattern in which an object has a string field which consists of its own yaml manifest. As an example, a ConfigMap may contain a manifest bundle in one of its data fields. A nested manifest will recurse and apply all object transforms to the underlying objects and then write the result back to the parent object.
3bc63ec
to
b5a5e00
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change adds support for applying object transforms to nested manifests. The nested manifest pattern is a pattern in which an object has a string field which consists of its own yaml manifest.
As an example, a ConfigMap may contain a manifest bundle in one of its data fields.
A nested manifest will recurse and apply all object transforms to the underlying objects and then write the result back to the parent object.