-
Notifications
You must be signed in to change notification settings - Fork 83
chore: stage ktest module #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should enable us to add a module much more easily, because `go mod tidy` will work.
This is intended to support #383 , which ends up needing a new shared library, but it proves very difficult to add a module and use it in one commit, even with go workspaces. I think creating a stub module (as here) should (1) work around the problem and (2) be a reasonable compromise in terms of breaking up commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, tomasaschan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justinsb This seems to have already happened on |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks @tomasaschan - good point - the bigger PR just merged 🎉 ! /close |
@justinsb: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This should enable us to add a module much more easily, because
go mod tidy
will work.