Skip to content

Conversation

@justinsb
Copy link
Contributor

Doing this makes permissions easier (no need for admin access) and also
ensures that tag operations go through PR review (which is nice from
a compliance perspective).

Inspired by similar work done by the kOps maintainers.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2025
@k8s-ci-robot k8s-ci-robot requested a review from atoato88 April 26, 2025 11:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2025
@justinsb
Copy link
Contributor Author

This doesn't replace the need to get you those permissions @tomasaschan , but hopefully it makes it less urgent!

…G_VERSION

Doing this makes permissions easier (no need for admin access) and also
ensures that tag operations go through PR review (which is nice from
a compliance perspective).

Inspired by similar work done by the kOps maintainers.
@tomasaschan
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9232800 into kubernetes-sigs:master Apr 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants