🐛 fix: webhook testEnv

[mateusoliveira43]

Enable conversion webhooks for webhook suite_test.go envtest by using k8s.io/client-go/kubernetes/scheme instead of creating new scheme (this also already done in controller suite_test.go)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mateusoliveira43
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @mateusoliveira43. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mateusoliveira43]

@camilamacedo86 will undo change to CRDInstallOptions, the default value is what I am adding

// Scheme is used to determine if conversion webhooks should be enabled
// for a particular CRD / object.
//
// Conversion webhooks are going to be enabled if an object in the scheme
// implements Hub and Spoke conversions.
//
// If nil, scheme.Scheme is used.

Will add more info to PR description

[camilamacedo86]

HI @mateusoliveira43

Can you rebase it with the master and ensure that you have what was changed and why in the description?

[mateusoliveira43]

@camilamacedo86 updated

[camilamacedo86]

HI @mateusoliveira43

Thanks for suggesting this! I’ve been thinking about it, and I believe we should stick to the current setup for a few reasons:

• It gives users granular control over adding only the API groups they need for their test cases, keeping things lightweight and precise. Not that it is not a bug. It is done in this one by design. Users can add ANY required scheme.
• Using client-go/kubernetes/scheme adds all API groups by default, which increases memory usage and makes debugging schema issues harder.

The current approach is more streamlined for custom resources, avoiding unnecessary complexity or conflicts.

/hold

Overall, I think the flexibility of the existing setup is better suited for varied test scenarios.
Let me know your thoughts!

Best,