✨Upgrade Golang version to v1.24.0

[dongjiang1989]

Upgrade go version 1.23 to 1.24

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @dongjiang1989!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

/ok-to-test

[camilamacedo86]

Why have we this change?

[dongjiang1989]

When golangci-lint to v1.64.5, some warning

$ golangci-lint --version
golangci-lint has version v1.64.5 built with go1.24.0 from (unknown, modified: ?, mod sum: "h1:5omC86XFBKXZgCrVdUWU+WNHKd+CWCxNx717KXnzKZY=") on (unknown)
$ golangci-lint run
pkg/plugin/util/util_test.go:23:2: dot-imports: should not use dot imports (revive)
	. "github.com/onsi/ginkgo/v2"
	^
pkg/plugin/util/util_test.go:24:2: dot-imports: should not use dot imports (revive)
	. "github.com/onsi/gomega"
	^
pkg/plugin/util/suite_test.go:22:2: dot-imports: should not use dot imports (revive)
	. "github.com/onsi/ginkgo/v2"

[camilamacedo86]

Could we open a PR for upgrade the lint and another for the Go
We also need check all places for the linter

[dongjiang1989]

Thanks @camilamacedo86
I got it
Will change it in next PR

[camilamacedo86]

Thank you a lot for check this one !!!!

[dongjiang1989]

@camilamacedo86 How to change golang version here?
ref: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kubebuilder/4585/pull-kubebuilder-test/1895464276731105280

Maybe change prow image image: public.ecr.aws/docker/library/golang:1.23 to image: public.ecr.aws/docker/library/golang:1.24

[camilamacedo86]

Hi @dongjiang1989

Maybe change prow image image: public.ecr.aws/docker/library/golang:1.23 to image: public.ecr.aws/docker/library/golang:1.24

We will need to update the the test-infra: http://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml#L14

Feel free to push a PR and ping me.
I will be happy to approve 👍

[dongjiang1989]

cc @camilamacedo86 kubernetes/test-infra#34430 PTAL

[k8s-ci-robot]

@dongjiang1989: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-test	4bca6c2	link	true	/test pull-kubebuilder-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[camilamacedo86]

Hi @dongjiang1989

I saw that you open the PR there as well.
Let's wait just a little ideally, we should only bump the Golang when it is bumped in the k8s API and controller-runtime and we bump here. But lets give a couple of weeks, then I think we can go.

[camilamacedo86]

Just for we keep tracked here:

• Update Golang version to 1.24 for kubebuilder unit test image kubernetes/test-infra#34430

[camilamacedo86]

@dongjiang1989

Let's bump controller-runtime latest release which still uses 1.23 : https://github.com/kubernetes-sigs/controller-runtime/blob/v0.20.3/go.mod

Do a patch release, and then I think we might can move forward with this one.

[dongjiang1989]

@dongjiang1989

Let's bump controller-runtime latest release which still uses 1.23 : https://github.com/kubernetes-sigs/controller-runtime/blob/v0.20.3/go.mod

Do a patch release, and then I think we might can move forward with this one.

Thanks @camilamacedo86
Got it.
controller-runtime master branch update golang version to v1.24:
kubernetes-sigs/controller-runtime@9d65299

Patch it to controller-runtime v0.20.x?