🌱 (chore): enable shadow checks via import-shadowing linter

[kersten]

Now that all variable shadowing issues have been resolved in previous commits, the shadow linter in govet is enabled and import-shadowing rule from revive is activated, to ensure consistent detection of future shadowing problems.

[k8s-ci-robot]

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

We probably should enable it for the scaffolds as well.

[kersten]

Great idea, let me check that out

[camilamacedo86]

We will need to get merged all PRs first,
Then, rebase it with master then we can move forward with this one.

[kersten]

We will need to get merged all PRs first, Then, rebase it with master then we can move forward with this one.

I will after all depended PRs are merged

[camilamacedo86]

/ok-to-test

[camilamacedo86]

/lgtm
/approved
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kersten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/lgtm