-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v4): enable 'import-shadowing' linter #4700
✨ (go/v4): enable 'import-shadowing' linter #4700
Conversation
Hi @kersten. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR adds the `import-shadowing` linter to all `.golangci.yml` configuration files across test projects and templates. The `import-shadowing` linter detects cases where a package import shadows an existing variable, which can lead to subtle bugs.
f3b5ace
to
9eae3eb
Compare
This one is an addition so the best, here would be ✨ ( new feature .. add a new linter ) |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, kersten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR adds the
import-shadowing
linter to all.golangci.yml
configuration files across test projects and templates.The
import-shadowing
linter detects cases where a package import shadows an existing variable, which can lead to subtle bugs.Motivation
Adding this linter helps maintain cleaner and more maintainable code by avoiding accidental name collisions.
This change aligns the lint configuration across the codebase and ensures new code follows the same checks.
Changes
import-shadowing
to:testdata/project-v4*/.golangci.yml
docs/book/src/**/testdata
pkg/plugins/golang/v4/scaffolds/internal/templates/golangci.go
No functional code changes were made—this is purely a tooling/linting update.