-
Notifications
You must be signed in to change notification settings - Fork 1.5k
✨Update golangci-lint to v2.1.0 and lint-action to v8 #4801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ansh-devs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ansh-devs! |
Hi @ansh-devs. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@camilamacedo86 PTAL |
@@ -18,6 +18,6 @@ jobs: | |||
go-version-file: go.mod | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All those empty files should not exist,
Can you please check them out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what happened was that permission was changed for a lot of files, but agree that should not happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mateusoliveira43 indeed this is the issue with permissions. let me check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you need #4801 (comment) otherwise we cannot get the PR merged.
|
||
- name: Running make test-e2e for ${{ matrix.folder }} | ||
working-directory: ${{ matrix.folder }} | ||
run: make test-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please keep only the required changes?
Otherwise, it makes it hard for us to identify what actually change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work! Before we can get this merged, could you please take care of a couple of small things?
✅ Please make sure the PR contains only one commit. This helps keep our Git history clean and easier to follow.
✅ Also, please ensure that only the required changes are included in the PR. Extra or unrelated changes can make it harder to review and understand what was actually modified.
✅ Last, we must ensure that the changes pass in the CI.
Otherwise, everything looks great — thanks again! 🙌
871256a
to
bf2c689
Compare
@camilamacedo86 I have squashed the commits please check... |
Hi @ansh-devs
The GitHub actions are reformatted when should only contain the required change Could you please ensure that all is == before and we have only in the diff we must change? |
Fixes #4798