Skip to content

✨Update golangci-lint to v2.1.0 and lint-action to v8 #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ansh-devs
Copy link

Fixes #4798

Copy link

linux-foundation-easycla bot commented May 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ansh-devs / name: Ansh Kumar Garhewal (3196ee7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ansh-devs
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @ansh-devs!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ansh-devs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 8, 2025
@ansh-devs
Copy link
Author

@camilamacedo86 PTAL

@@ -18,6 +18,6 @@ jobs:
go-version-file: go.mod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those empty files should not exist,
Can you please check them out?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what happened was that permission was changed for a lot of files, but agree that should not happen

Copy link
Author

@ansh-devs ansh-devs May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateusoliveira43 indeed this is the issue with permissions. let me check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you need #4801 (comment) otherwise we cannot get the PR merged.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 9, 2025

- name: Running make test-e2e for ${{ matrix.folder }}
working-directory: ${{ matrix.folder }}
run: make test-e2e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please keep only the required changes?
Otherwise, it makes it hard for us to identify what actually change

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work! Before we can get this merged, could you please take care of a couple of small things?

✅ Please make sure the PR contains only one commit. This helps keep our Git history clean and easier to follow.

✅ Also, please ensure that only the required changes are included in the PR. Extra or unrelated changes can make it harder to review and understand what was actually modified.

✅ Last, we must ensure that the changes pass in the CI.

Otherwise, everything looks great — thanks again! 🙌

@ansh-devs ansh-devs force-pushed the master branch 2 times, most recently from 871256a to bf2c689 Compare May 9, 2025 16:32
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2025
@ansh-devs ansh-devs closed this May 9, 2025
@ansh-devs ansh-devs reopened this May 9, 2025
@ansh-devs
Copy link
Author

@camilamacedo86 I have squashed the commits please check...

@camilamacedo86
Copy link
Member

Hi @ansh-devs

@camilamacedo86 I have squashed the commits please check...

The GitHub actions are reformatted when should only contain the required change
See my comment: https://github.com/kubernetes-sigs/kubebuilder/pull/4801/files#r2081509240

Could you please ensure that all is == before and we have only in the diff we must change?
So, that we can trigger the tests and see if that will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade golangci-lint and align across Kubebuilder and scaffolds
4 participants