-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 (docs): Limit code rendering to relevant sections in multiversion webhook tutorial #5372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 (docs): Limit code rendering to relevant sections in multiversion webhook tutorial #5372
Conversation
|
Hi @BadisLaffet1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Terrific !!!
Thank you a lot for the amazing work 🎉
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BadisLaffet1, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm Thank you! |
6e7e853
into
kubernetes-sigs:master
|
@BadisLaffet1: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
📖 (docs): Limit code rendering to relevant sections in multiversion webhook tutorial
Fixes #5232
Problem
The multiversion webhook tutorial was showing entire file contents instead of only the relevant code sections:
Root Cause
The generation scripts in
hack/docs/internal/multiversion-tutorial/were missing collapse markers to hide non-essential code from the rendered documentation.Changes Made
File 1:
hack/docs/internal/multiversion-tutorial/generate_multiversion.goupdateWebhookV2() function - Added imports collapse marker:
updateMain() function - Added Manager Setup collapse marker (Lin:
updateMain() function - Removed existing setup doc marker insertion :
File 2:
hack/docs/internal/multiversion-tutorial/webhook_v2_implementaton.gocronJobValidationFunction constant - Added collapse marker before validation functions :
Result
Webhook v2 (
cronjob_webhook.go)validateCronJob,validateCronJobName,validateCronJobSpec,validateScheduleFormat)main.go