-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support oci in helm-app and custom_cni #11978
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: borislitv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @borislitv. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
579aef5
to
71cac33
Compare
@tico88612 @yankay Hi guys, everything seems to work |
rebased @tico88612 @yankay FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to change the testcase script?
Can you explain the need for this behavior?
Apparently the dependence is updated after pr merge, in any case now there is an old library and the test is falling. No image with new dependencies appears on the request pool. Probably after the merge can be removed. |
@tico88612 I read the documentation again, kubernetes.core collection is part of the ansible package, so it needs to be updated via ansible-galaxy. As a result, through the new image should work, but apparently will not work through the local environment (made through pip |
The CI needs to pass |
it doesn't seem to have crashed because of my changes, all the tests passed before the rebase, but I'll look again. And what to do with dependencies? |
According to the changelog https://github.com/ansible-community/ansible-build-data/blob/main/11/CHANGELOG-v11.md#unchanged-collections the best way would be to upgrade ansible to 11.3.0 |
@borislitv #11924 is WIP. |
great news! Unfortunately I need at least 11.3.0, otherwise my pull request should wait for an update. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I'll wait #11924 and then try to up ansible version -> 11.3.0 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
support oci helm repo in helm-app
support oci helm repo in custom_cni
Which issue(s) this PR fixes:
#10712
Special notes for your reviewer:
custom_cni example vars:
Does this PR introduce a user-facing change?: