Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support oci in helm-app and custom_cni #11978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borislitv
Copy link
Contributor

@borislitv borislitv commented Feb 19, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
support oci helm repo in helm-app
support oci helm repo in custom_cni

Which issue(s) this PR fixes:
#10712

Special notes for your reviewer:
custom_cni example vars:

custom_cni_chart_release_name: "calico"
custom_cni_chart_namespace: "tigera-operator"
custom_cni_chart_ref: "oci://test.registry.net:5000/helm-charts/calico"
custom_cni_chart_version: "0.3.1"
custom_cni_chart_auth_username: "test-user"
custom_cni_chart_auth_password: "test-password"

Does this PR introduce a user-facing change?:

support oci helm repo

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: borislitv
Once this PR has been reviewed and has the lgtm label, please assign floryut for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @borislitv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 19, 2025
@tico88612
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2025
@borislitv
Copy link
Contributor Author

/retest

@borislitv borislitv force-pushed the helm-oci branch 4 times, most recently from 579aef5 to 71cac33 Compare February 20, 2025 09:41
@borislitv
Copy link
Contributor Author

borislitv commented Feb 21, 2025

@tico88612 @yankay Hi guys, everything seems to work
Please see my changes for approval

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 26, 2025
@borislitv
Copy link
Contributor Author

rebased @tico88612 @yankay FYI

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to change the testcase script?
Can you explain the need for this behavior?

@borislitv
Copy link
Contributor Author

borislitv commented Mar 7, 2025

Why do you need to change the testcase script?
Can you explain the need for this behavior?

Apparently the dependence is updated after pr merge, in any case now there is an old library and the test is falling. No image with new dependencies appears on the request pool. Probably after the merge can be removed.
/retest

@borislitv
Copy link
Contributor Author

@tico88612 I read the documentation again, kubernetes.core collection is part of the ansible package, so it needs to be updated via ansible-galaxy. As a result, through the new image should work, but apparently will not work through the local environment (made through pip
). Therefore, I need advice: how to solve such problems with dependences?

@yankay
Copy link
Member

yankay commented Mar 10, 2025

The CI needs to pass

@borislitv
Copy link
Contributor Author

borislitv commented Mar 10, 2025

The CI needs to pass

it doesn't seem to have crashed because of my changes, all the tests passed before the rebase, but I'll look again. And what to do with dependencies?
p.s. fixed with another rebase

@borislitv
Copy link
Contributor Author

According to the changelog https://github.com/ansible-community/ansible-build-data/blob/main/11/CHANGELOG-v11.md#unchanged-collections the best way would be to upgrade ansible to 11.3.0
Is it possible to update ansible version? I could try

@tico88612
Copy link
Member

@borislitv #11924 is WIP.

@borislitv
Copy link
Contributor Author

borislitv commented Mar 10, 2025

@borislitv #11924 is WIP.

great news! Unfortunately I need at least 11.3.0, otherwise my pull request should wait for an update.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@borislitv
Copy link
Contributor Author

I'll wait #11924 and then try to up ansible version -> 11.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants