-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize kubelet root directory (/var/lib/kubelet) #11988
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ant31 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
20f8177
to
5114f19
Compare
/retest |
/ok-to-test |
/hold It's not so easy to change the default. Too many operator, csi and other software in the ecosystem have hardcoded /var/lib/kubelet. |
04f4526
to
fe4f805
Compare
/unhold PR is ready. |
What type of PR is this?
What this PR does / why we need it:
In some situation, users wants to use a different directory than the default "/var/lib/kubelet'.
It was previously possible by setting the
kubelet_custom_flags
but many roles were still hardcoded to "/var/lib/kubelet".Which issue(s) this PR fixes:
Fixes #7087
Special notes for your reviewer:
Not sure the best way to handle users that were using the
kubelet_custom_flags
.Does this PR introduce a user-facing change?: