-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[argocd] Bump ArgoCD version to 2.14.5 #12041
Conversation
|
Welcome @farshadasadpour! |
Hi @farshadasadpour. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@oomichi Could you please
|
/ok-to-test |
@farshadasadpour Edit the release-note in your PR content like this. kubespray/.github/PULL_REQUEST_TEMPLATE.md Lines 42 to 44 in 16b090c
|
81dd375
to
49def7f
Compare
/hold |
Hi @tico88612 Thank you for pointing that out regarding the alignment between the commit message and the PR title. I actually realized the misalignment shortly before seeing your message and have already fixed it. I appreciate your guidance on this and your sharp observation—it’s always helpful to have another set of eyes during the review process. If there's anything else you think I should adjust or improve, please let me know. |
/retest-failed |
@tico88612 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind feature
/unhold
/lgtm
/release-note-edit
[argocd] Bump ArgoCD version to 2.14.5
I would appreciate it if you could review this PR whenever you have time. The changes address compatibility with Kubernetes version If everything looks good after your review, it would be great to have your Thank you for your time and assistance! |
Thanks @farshadasadpour |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: farshadasadpour, tico88612, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@farshadasadpour Rebase your PR to fix the CI result. |
Please use rebase instead merge commit. |
Hi @tico88612 I believe I may have made a mistake with my PR, and I'm looking to rectify it. I want to ensure it meets the repository's standards and seamlessly integrates with the existing codebase. Would you be able to offer some guidance or advice on how best to address this issue? Your expertise would be greatly appreciated. Thank you for your understanding and suppot |
@farshadasadpour remove merge commit from your PR and rebase from our upstream. Maybe you need to force push it. FYI: https://www.atlassian.com/git/tutorials/merging-vs-rebasing |
According to the official ArgoCD documentation, version 2.14.5 is required for compatibility with Kubernetes version 1.31 Reference: https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/\#tested-versions docs(argocd): update version references in documentation and configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
/lgtm
According to the official ArgoCD documentation, version 2.14.5 is required for compatibility with Kubernetes version 1.31.
Reference: https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/\#tested-versions
What type of PR is this?
What this PR does / why we need it:
Updates ArgoCD to version 2.14.5 for compatibility with Kubernetes version 1.31, as recommended by the official ArgoCD documentation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Ensure compatibility by updating ArgoCD to the recommended version. Verified against the official documentation.
Does this PR introduce a user-facing change?: