Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argocd] Bump ArgoCD version to 2.14.5 #12041

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

farshadasadpour
Copy link
Contributor

@farshadasadpour farshadasadpour commented Mar 15, 2025

According to the official ArgoCD documentation, version 2.14.5 is required for compatibility with Kubernetes version 1.31.

Reference: https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/\#tested-versions

What type of PR is this?

/kind feature

What this PR does / why we need it:
Updates ArgoCD to version 2.14.5 for compatibility with Kubernetes version 1.31, as recommended by the official ArgoCD documentation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Ensure compatibility by updating ArgoCD to the recommended version. Verified against the official documentation.

Does this PR introduce a user-facing change?:

ArgoCD updated to version 2.14.5 to maintain compatibility with Kubernetes version 1.31.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 15, 2025
@k8s-ci-robot k8s-ci-robot requested review from VannTen and yankay March 15, 2025 20:01
Copy link

linux-foundation-easycla bot commented Mar 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: farshadasadpour / name: Farshad Asadpour (93338a0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 15, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @farshadasadpour!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @farshadasadpour. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 15, 2025
@farshadasadpour
Copy link
Contributor Author

@oomichi Could you please /approve this PR? It has passed review and testing requirements.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: farshadasadpour Once this PR has been reviewed and has the lgtm label, please assign oomichi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@farshadasadpour
Copy link
Contributor Author

Hi @VannTen and @yankay, could you please review this PR and provide /lgtm and /ok-to-test if appropriate? This change is necessary for compatibility with Kubernetes v1.31, as suggested in the official ArgoCD documentation.

@VannTen
Copy link
Contributor

VannTen commented Mar 16, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2025
@farshadasadpour
Copy link
Contributor Author

Hi @yankay, @VannTen,
Could you please review this PR when you have time? Some CI checks have failed, and I’d appreciate your feedback on what needs to be fixed. Let me know if I need to make any changes. Thanks!

@tico88612
Copy link
Member

@farshadasadpour Edit the release-note in your PR content like this.

```release-note
```

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2025
@yankay
Copy link
Member

yankay commented Mar 18, 2025

Hi @VannTen and @yankay, could you please review this PR and provide /lgtm and /ok-to-test if appropriate? This change is necessary for compatibility with Kubernetes v1.31, as suggested in the official ArgoCD documentation.

HI @farshadasadpour

Thanks for the PR. And the README.md also needs to update to Pass the CI.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2025
@farshadasadpour farshadasadpour force-pushed the master branch 2 times, most recently from 81dd375 to 49def7f Compare March 18, 2025 05:01
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 18, 2025
@farshadasadpour
Copy link
Contributor Author

Hi @VannTen and @yankay, could you please review this PR and provide /lgtm and /ok-to-test if appropriate? This change is necessary for compatibility with Kubernetes v1.31, as suggested in the official ArgoCD documentation.

HI @farshadasadpour

Thanks for the PR. And the README.md also needs to update to Pass the CI.

@tico88612
Copy link
Member

/hold
Commit message not align with the PR title.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2025
@farshadasadpour
Copy link
Contributor Author

/hold Commit message not align with the PR title.

Hi @tico88612

Thank you for pointing that out regarding the alignment between the commit message and the PR title. I actually realized the misalignment shortly before seeing your message and have already fixed it. I appreciate your guidance on this and your sharp observation—it’s always helpful to have another set of eyes during the review process.

If there's anything else you think I should adjust or improve, please let me know.

@tico88612
Copy link
Member

/retest-failed

@farshadasadpour
Copy link
Contributor Author

/retest-failed

@tico88612
Thank you for retrying the failed tests. I’ll monitor the results closely to ensure everything passes. Please let me know if there’s anything else I need to address.

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind feature
/unhold
/lgtm
/release-note-edit

[argocd] Bump ArgoCD version to 2.14.5

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 18, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@farshadasadpour
Copy link
Contributor Author

Hi @yankay and @VannTen,

I would appreciate it if you could review this PR whenever you have time. The changes address compatibility with Kubernetes version 1.31 by upgrading ArgoCD to the latest stable release 2.14.5.

If everything looks good after your review, it would be great to have your /lgtm and /approve so the PR can move forward. Please let me know if you notice anything that needs adjustment.

Thank you for your time and assistance!

@yankay
Copy link
Member

yankay commented Mar 21, 2025

Hi @yankay and @VannTen,

I would appreciate it if you could review this PR whenever you have time. The changes address compatibility with Kubernetes version 1.31 by upgrading ArgoCD to the latest stable release 2.14.5.

If everything looks good after your review, it would be great to have your /lgtm and /approve so the PR can move forward. Please let me know if you notice anything that needs adjustment.

Thank you for your time and assistance!

Thanks @farshadasadpour
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: farshadasadpour, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@tico88612
Copy link
Member

@farshadasadpour Rebase your PR to fix the CI result.

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 21, 2025
@tico88612
Copy link
Member

Please use rebase instead merge commit.

@farshadasadpour
Copy link
Contributor Author

Hi @tico88612

I believe I may have made a mistake with my PR, and I'm looking to rectify it. I want to ensure it meets the repository's standards and seamlessly integrates with the existing codebase.

Would you be able to offer some guidance or advice on how best to address this issue? Your expertise would be greatly appreciated.

Thank you for your understanding and suppot

@tico88612
Copy link
Member

@farshadasadpour remove merge commit from your PR and rebase from our upstream. Maybe you need to force push it.

FYI: https://www.atlassian.com/git/tutorials/merging-vs-rebasing

According to the official ArgoCD documentation, version 2.14.5 is required
for compatibility with Kubernetes version 1.31

Reference: https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/\#tested-versions

docs(argocd): update version references in documentation and configuration
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit bab6a9b into kubernetes-sigs:master Mar 21, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants