Open
Conversation
The vagrant test jobs don't actually need to wait for pre-commit, and the kubevirt jobs don't need to wait for vagrant-validate.
k8s-ci-robot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
Contributor
Author
|
/label ci-full |
Contributor
Author
|
/retest |
VannTen
force-pushed
the
ci/cleanup_vagrant
branch
from
fd25f9a to
6060ccd
Compare
VannTen
force-pushed
the
ci/cleanup_vagrant
branch
from
6060ccd to
7782a6c
Compare
Contributor
Author
|
/retest-failed |
1 similar comment
Contributor
Author
|
/retest-failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since b9e251a (CI: cleanup terraform + deduplicate and simplify, 2025-03-14), the vagrant CI does not actually work, because Ansible does not see the hosts created !
This restore the behaviour or copying the vagrant inventory to make it available to the playbook.
Also some simplifying of dependencies to have the vagrant jobs not wait on pre-commit (which can take some time with ansible-lint)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: