Move package management related config to system_packages#12830
Open
VannTen wants to merge 1 commit intokubernetes-sigs:masterfrom
Open
Move package management related config to system_packages#12830VannTen wants to merge 1 commit intokubernetes-sigs:masterfrom
VannTen wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
Contributor
Author
|
/label ci-extended |
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
ci-extended
k8s-ci-robot
added
the
size/L
VannTen
force-pushed
the
cleanup/bootstrap_pkg_mgmt
branch
from
ea31a03 to
3746fe9
Compare
k8s-ci-robot
added
the
needs-rebase
boostrap_os initial purpose is to provision Python on managed nodes which don't have it pre-installed. Some OS specifics tasks here are in fact related to package management (installing extra packages sources like epel, package manager proxy settings). Move all of those to system_packages, allowing to eliminate some call to the setup module.
VannTen
force-pushed
the
cleanup/bootstrap_pkg_mgmt
branch
from
3746fe9 to
332f74f
Compare
k8s-ci-robot
removed
the
needs-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
boostrap_os initial purpose is to provision Python on managed nodes
which don't have it pre-installed.
Some OS specifics tasks here are in fact related to package management
(installing extra packages sources like epel, package manager proxy
settings).
Move all of those to system_packages, allowing to eliminate some call to
the setup module.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This should not modify behavior I think but let's wait for CI results
Does this PR introduce a user-facing change?: