fix(download): Correct Youki download URL for arm64 architecture#12956
fix(download): Correct Youki download URL for arm64 architecture#12956burxtx wants to merge 2 commits intokubernetes-sigs:masterfrom
Conversation
|
Hi @burxtx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Hey @burxtx, could you write the release note? |
OK, release-note added. |
|
Thanks @burxtx |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: burxtx, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VannTen
left a comment
There was a problem hiding this comment.
We already have the mapping in the other direction (host_architecture)( Which btw seems weird because I think ansible_arch can have the values used as key there).
Can you please instead add a dict alt_arch (or something like that) and use that (
alt_arch:
arch1: alt_arch_name
...There is one in
but it's not in YAML.On systems where ansible_architecture is reported as 'arm64' (such as Apple Silicon Macs), downloading Youki fails because the release artifacts are named with 'aarch64'.
|
Adding label DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@VannTen Thanks for the review, I also noticed the |
VannTen
left a comment
There was a problem hiding this comment.
One comment (also, no need to rebase / merge unless the bot detect a conflict, but if you need to , you should do something like git rebase master from your branch.
| alt_host_arch: >- | ||
| {%- if ansible_architecture in _alt_arch_name -%} | ||
| {{ _alt_arch_name[ansible_architecture] }} | ||
| {%- else -%} | ||
| {{ ansible_architecture }} | ||
| {%- endif -%} |
There was a problem hiding this comment.
Don't bother with that, this would only mask errors.
just setup the dict, and if you can have one entry for each supported arch for youki that should be enough.
Then just use alt_arch_name[ansible_architecture] directly on use site.
This PR fixes an issue with downloading Youki on systems where Ansible reports the architecture as
arm64, such as Apple Silicon Macs. Theyouki_download_urlwas using{{ ansible_architecture }}directly, which results inarm64in the URL. However, Youki's release artifacts useaarch64for this architecture, leading to a "404 Not Found" error when trying to download the component.What type of PR is this?
What this PR does / why we need it:
This change introduces a conditional to map
arm64toaarch64for both theyouki_download_urland the local destination file path (downloads.youki.dest), resolving the download failure.Which issue(s) this PR fixes:
Fixes #12950
Special notes for your reviewer:
Does this PR introduce a user-facing change?: