proxy: Fix the no_proxy variable#12981
proxy: Fix the no_proxy variable#12981VannTen wants to merge 2 commits intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-2.30 |
|
@VannTen: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
999ced5 to
46712c5
Compare
|
/cc @tico88612 |
|
/hold |
46712c5 to
3a20634
Compare
|
/hold cancel |
|
@1337andre could you verify this one? |
3a20634 to
b851003
Compare
|
Ugh, from a quick grep in bootstrap_os we don't add (the fix did work for our clusters with a proxy but I need to think on how to add a regression test which does not need a real proxy server 🤔 ) |
68e79fe to
caff34a
Compare
|
Looks like ansible 2.18 is more strict on allowing transient undefined ? I think |
|
That variable will disappear in #12897 anyway. |
829436b to
0a6d01c
Compare
6ae0b47 to
9896544
Compare
Since 2.29, probably due to a change in ansible templating, the no_proxy variable is rendered as an array of character rather than a string. This results in broken cluster in some case. Eliminate the custom jinja looping to use filters and list flatteing + join instead. Also simplify some things (no separate tasks file, just use `run_once` instead of delegating to localhost)
9896544 to
dc34a32
Compare
|
/cc @tico88612 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
#12872 causes the
no_proxyvariable is rendered as an array of character rather than a string. (weird interaction between the manual jinja templating and the select ?)This results in broken cluster in some case.
Eliminate the custom jinja looping to use filters and list flatteing +
join instead.
Also simplify some things (no separate tasks file, just use
run_onceinstead of delegating to localhost)
Which issue(s) this PR fixes:
Fixes #12977
Special notes for your reviewer:
Does this PR introduce a user-facing change?: