Skip to content

proxy: Fix the no_proxy variable#12981

Open
VannTen wants to merge 2 commits intokubernetes-sigs:masterfrom
VannTen:cleanup/no_proxy
Open

proxy: Fix the no_proxy variable#12981
VannTen wants to merge 2 commits intokubernetes-sigs:masterfrom
VannTen:cleanup/no_proxy

Conversation

@VannTen
Copy link
Contributor

@VannTen VannTen commented Feb 10, 2026

What type of PR is this?
/kind bug

What this PR does / why we need it:
#12872 causes the no_proxy variable is rendered as an array of character rather than a string. (weird interaction between the manual jinja templating and the select ?)

This results in broken cluster in some case.

Eliminate the custom jinja looping to use filters and list flatteing +
join instead.
Also simplify some things (no separate tasks file, just use run_once
instead of delegating to localhost)

Which issue(s) this PR fixes:
Fixes #12977

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix broken NO_PROXY variable

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 10, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2026
@k8s-ci-robot k8s-ci-robot requested a review from yankay February 10, 2026 10:35
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2026
@VannTen
Copy link
Contributor Author

VannTen commented Feb 10, 2026

/cherrypick release-2.30
/cherrypick release-2.29

@k8s-infra-cherrypick-robot

@VannTen: once the present PR merges, I will cherry-pick it on top of release-2.29, release-2.30 in new PRs and assign them to you.

Details

In response to this:

/cherrypick release-2.30
/cherrypick release-2.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@VannTen
Copy link
Contributor Author

VannTen commented Feb 10, 2026

/cc @tico88612

@VannTen
Copy link
Contributor Author

VannTen commented Feb 10, 2026

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026
@VannTen
Copy link
Contributor Author

VannTen commented Feb 10, 2026

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026
@tico88612
Copy link
Member

@1337andre could you verify this one?

@VannTen
Copy link
Contributor Author

VannTen commented Feb 11, 2026

Ugh, from a quick grep in bootstrap_os we don't add no_proxy to package management config (why ?) so the check with and invalid proxy server is not gonna work 🤔

(the fix did work for our clusters with a proxy but I need to think on how to add a regression test which does not need a real proxy server 🤔 )

@VannTen VannTen force-pushed the cleanup/no_proxy branch 2 times, most recently from 68e79fe to caff34a Compare February 12, 2026 09:01
@VannTen
Copy link
Contributor Author

VannTen commented Feb 12, 2026

Looks like ansible 2.18 is more strict on allowing transient undefined ? I think <undefined val>.key in a list then filtering by undefined worked before ... 🤔 Oh well.

@VannTen
Copy link
Contributor Author

VannTen commented Feb 12, 2026

That variable will disappear in #12897 anyway.

@VannTen VannTen force-pushed the cleanup/no_proxy branch 3 times, most recently from 829436b to 0a6d01c Compare February 12, 2026 13:10
@VannTen VannTen force-pushed the cleanup/no_proxy branch 5 times, most recently from 6ae0b47 to 9896544 Compare February 12, 2026 15:41
Since 2.29, probably due to a change in ansible templating, the no_proxy
variable is rendered as an array of character rather than a string.

This results in broken cluster in some case.

Eliminate the custom jinja looping to use filters and list flatteing +
join instead.
Also simplify some things (no separate tasks file, just use `run_once`
instead of delegating to localhost)
@VannTen
Copy link
Contributor Author

VannTen commented Feb 17, 2026

/cc @tico88612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong rendered /etc/systemd/system/containerd.service.d/http-proxy.conf with no_proxy

4 participants